Re: checkRight() patch

On Fri, 2005-08-26 at 16:28 +0200, Lukas Kahwe Smith wrote:
> Hi,
> 
> what do people think about the following patch? essentially it means 
> that right_id === 0 checks return LIVEUSER_MAX_LEVEL if the user is 
> logged in (even if there is no perm user id mapping).
> 
> RCS file: /repository/pear/LiveUser/LiveUser.php,v
> retrieving revision 1.101
> diff -r1.101 LiveUser.php
> 1451a1452,1453
>  >         } elseif ($rights === 0 && is_a($this->_auth, 
> 'LiveUser_Auth_Common')) {
>  >             return LIVEUSER_MAX_LEVEL;

I fail to see how that will benefit us, if you'd explain it a little
then I might change my mind.

Maybe we should just keep it at returning the lowest level, thus keeping
maybe a tad secure against stray users.
I know we usually go with the thought "higher numbers out score the
lower" permission wise but I think we should make a exception in this
case unless something else lies behind this change :P

- Helgi