Re: $this->propertyValues['is_active'] shouldn't that be rather an overridable method?

Lukas Kahwe Smith schrieb:
>> I think that this is not good style, because
>> $this->propertyValues['is_active'] is not set in common.php, but in a
>> child class. I think that this should be in a method that can be
>> overridden by the child class,
> 
> 
> I understand your point. But we access propertyValues in several places.
> Especially in the freeze() and unfreeze() method where anything else
> would be rather convulted, especially since the structure of
> propertyValues is defined by the configured table fields.
> 
>> without passing return values through undocumented properties. What do
>> you think?
> 
> 
> well they are not documented because they are configurable .. however
> some optional parameters have special meaning like is_active and lastlogin.

I agree there is no need for 'normal' properties to have a getter
method, but I think that for lastlogin and is_active, there should be an
overridable method. I tried a grep for propertyValues, and I think only
common.php would need to be changed in 3 places for the auth containers.
But it's your baby, so if you disagree i will just override the whole
login method.

regards
Georg