Re: LiveUser_Auth_Propel Container 0.1

Georg Gell wrote:

> I have finished the first version for the LiveUser_Auth_Propel. It is
> working well for my test configuration.
> You can find it at http://tools.have2.com/LiveUser/LiveUser/Auth/Propel.phps
> Can you please check if I have missed to set any properties that
> LiveUser expects the Auth containers to have.

Hmm I am not really happpy with the implementation.

readUserData() is a public method. it needs to be defined because its 
called from the LiveUser class.

as such I do not see a need to overwrite login(). you should be able to 
do anything inside the init() method that may need to get initialized 
beforehand.

if you insist to overwrite login() please not the following: your 
login() implementation takes a blacklist approach. i think its better to 
check if the person is active (or if active is not enabled), instead of 
checking the user is not active.

hmm reading the source again and remember your comments .. i guess the 
entire story revolves around the propertyValues() array? .. there is 
really no way around it. unless you essentially overwrite every single 
method in the common implementation. its also used in the freeze() and 
unfreeze() method. i am open to finding a better solution, though i dont 
see turning everything into set/get method as a viable solution. if that 
is necessary for propel, then imho its broken.

hmm maybe we can remove propertyValues from the common implementation, 
so that you can use overloading?

regards,
Lukas