Re: LiveUser_Auth_Propel 0.2
Lukas Kahwe Smith <[email protected]> Fri, 02 Sep 2005 13:04:16 +0200
| Newsgroups | gmane.comp.php.pear.liveuser |
|---|---|
| Message-ID | <[email protected]> |
Georg Gell wrote:
> hi list,
>
> second version
> http://tools.have2.com/LiveUser/LiveUser/Auth/Propel_0.2.phps
> I think I incorporated all tips that Lukas gave me. i am testing it at
> the moment, please have a look ;)
looks better .. though you still do:
if (!$this->user->$getIsActive()) {
instead of the other way around .. so it goes ..
I used to write code like the following as well:
if (isset($this->authTableProperties['is_active'])) {
nowadays I try to use array_key_exists() instead unless i specifically
want to not include NULL values ..
i am sure that NULL would not be a valid value for authTableProperties
the rest of the code to work, but in this place i think you care more
about if the key is set, than what the value is ..
regards,
Lukas