Re: PDO driver in CVS
Arnaud Limbourg <arnaud-GdXxm9JVFPlWk0Htik3J/[email protected]> Tue, 06 Dec 2005 21:44:59 +0100
| Newsgroups | gmane.comp.php.pear.liveuser |
|---|---|
| Message-ID | <[email protected]> |
>> The code does the check on elements presence (or should :)
>
> it does not ..
>
> $options = $login = $password = $extra = null;
> if (isset($conf['storage']['options'])) {
> $options = $conf['storage']['options'];
> $login = $options['user'];
> $password = $options['passwd'];
> if (isset($options['attr'])) {
> $extra = $options['attr'];
> }
> }
>
> so if you have options you must have a username and password defined
> even if you just care about attributes (or username) ..
MM, indeed. Overlook on my part.
> btw .. the keys should probably be username and password as well ..
PDO calls that login so do we want to name it login or username. I think
username would be more consistent with what it is called everywhere.
> regards,
> Lukas
>
>
> _______________________________________________
> LiveUser mailing list
> [email protected]
> http://mailman.21st-hq.de/mailman/listinfo/liveuser