Req #55672 [Opn->Csd]: Autoguessing TEST_PHP_EXECUTABLE if none is provided in run-tests.php
| Newsgroups | gmane.comp.php.quality-assurance |
|---|---|
| Message-ID | <[email protected]> |
Edit report at https://bugs.php.net/bug.php?id=55672&edit=1 ID: 55672 Updated by: [email protected] Reported by: [email protected] Summary: Autoguessing TEST_PHP_EXECUTABLE if none is provided in run-tests.php -Status: Open +Status: Closed Type: Feature/Change Request Package: Testing related PHP Version: trunk-SVN-2011-09-12 (SVN) -Assigned To: +Assigned To: nikic Block user comment: N Private report: N New Comment: Nowadays run-tests.php defaults to using PHP_BINARY (formerly -P), as usually the same binary is used for running and testing. Previous Comments: ------------------------------------------------------------------------ [2011-09-26 22:50:35] [email protected] Alex, maybe you should submit the getenv part of the patch separately to https://bugs.php.net/bug.php?id=53617 as it seems that we have a general agreement on fixing that. Tyrael ------------------------------------------------------------------------ [2011-09-15 20:38:23] [email protected] This patch is not about guessing php executable that runs run-tests.php, but is about php binary to be tested, these are often different binaries. ------------------------------------------------------------------------ [2011-09-12 14:19:26] [email protected] how about use $0 ? ------------------------------------------------------------------------ [2011-09-12 12:29:48] [email protected] Description: ------------ Hello! I've made some improvements to run-tests.php: 1) Autoguessing TEST_PHP_EXECUTABLE and TEST_PHP_CGI_EXECUTABLE if they're not provided, i.e. assume they have value 'auto'. You can still pass your own value as usual. Autoguessing is done this way: Looking for ./sapi/cli/php from the current directory, and, if not found from directory where run-tests.php script is resides (Christofer Jones suggestion). php-cgi is looked for the same way. 2) Added option -n (use no php.ini) to the shebang line (#!/usr/bin/php -n) so it would run more reliably on some hosts. My Ubuntu setup did not have E letter in variables_order (i.e. variables_order=GPCS) so $_ENV array was empty and some tests were skipped when they could be run. 3) Some better error handling of wrong paths So now you can run run-tests.php with just $ ./run-tests.php ext instead of $ TEST_PHP_EXECUTABLE=auto php -n run-tests.php ext You can also run run-tests.php from sub-dir, it will correctly guess 'auto' as well: $ cd ext/ $ ../run-tests.php zlib ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=55672&edit=1