[PHP-BUG] Bug #80018 [NEW]: Tests expect var_dump(FLOAT) to print an integer

From:             jamieliu at google dot com
Operating system: All
PHP version:      master-Git-2020-08-25 (Git)
Package:          Testing related
Bug Type:         Bug
Bug description:Tests expect var_dump(FLOAT) to print an integer

Description:
------------
Many tests parse the result of var_dump() on a float and expect the
result to be an integer:

$ find . -name '*.phpt' | xargs grep 'float(%d)'
./Zend/tests/cast_to_double.phpt:float(%d)
./Zend/tests/settype_double.phpt:float(%d)
./ext/standard/tests/file/disk_total_space_basic.phpt:float(%d)
./ext/standard/tests/file/disk_total_space_basic.phpt:float(%d)
./ext/standard/tests/file/disk_total_space_basic.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk.phpt:float(%d)
./ext/standard/tests/file/disk.phpt:float(%d)
./ext/standard/tests/file/disk_total_space_error.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_error.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_error.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_basic.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_basic.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_basic.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_basic.phpt:float(%d)
./ext/standard/tests/file/disk_free_space_basic.phpt:float(%d)
./ext/standard/tests/file/disk_total_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_total_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_total_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_total_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_total_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_total_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_total_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_total_space_variation.phpt:float(%d)
./ext/standard/tests/file/disk_total_space_variation.phpt:float(%d)
./ext/standard/tests/general_functions/type.phpt:float(%d)
./ext/standard/tests/general_functions/type.phpt:float(%d)
./ext/standard/tests/general_functions/type.phpt:float(%d)
./ext/standard/tests/general_functions/gettype_settype_basic.phpt:float(%d)
./ext/standard/tests/general_functions/gettype_settype_basic.phpt:float(%d)
./ext/standard/tests/general_functions/gettype_settype_basic.phpt:float(%d)
./ext/standard/tests/general_functions/gettype_settype_basic.phpt:float(%d)

This is problematic because var_dump() will print sufficiently large
numbers in exponential notation. An example in Linux:

$ mkdir tmp
$ sudo mount -t tmpfs -o size=$((1 << 62)) tmpfs tmp
$ ~/src/php-src/sapi/cli/php --version
PHP 8.0.0-dev (cli) (built: Aug 25 2020 12:55:38) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.0-dev, Copyright (c) Zend Technologies
$ ~/src/php-src/sapi/cli/php -r 'var_dump(disk_total_space("tmp"));'
float(4.611686018427388E+18)

I think every instance of "float(%d)" in such tests could simply be
converted to use "float(%E)" instead.

Test script:
---------------
See description.


-- 
Edit bug report at https://bugs.php.net/bug.php?id=80018&edit=1
-- 
Fix committed:                    https://bugs.php.net/fix.php?id=80018&r=fixed
Fixed in release:                 https://bugs.php.net/fix.php?id=80018&r=alreadyfixed
Need backtrace:                   https://bugs.php.net/fix.php?id=80018&r=needtrace
Need Reproduce Script:            https://bugs.php.net/fix.php?id=80018&r=needscript
Try newer version:                https://bugs.php.net/fix.php?id=80018&r=oldversion
Not developer issue:              https://bugs.php.net/fix.php?id=80018&r=support
Expected behavior:                https://bugs.php.net/fix.php?id=80018&r=notwrong
Not enough info:                  https://bugs.php.net/fix.php?id=80018&r=notenoughinfo
Submitted twice:                  https://bugs.php.net/fix.php?id=80018&r=submittedtwice
register_globals:                 https://bugs.php.net/fix.php?id=80018&r=globals
PHP version support discontinued: https://bugs.php.net/fix.php?id=80018&r=phptooold
Daylight Savings:                 https://bugs.php.net/fix.php?id=80018&r=dst
IIS Stability:                    https://bugs.php.net/fix.php?id=80018&r=isapi
Install GNU Sed:                  https://bugs.php.net/fix.php?id=80018&r=gnused
Floating point limitations:       https://bugs.php.net/fix.php?id=80018&r=float
No Zend Extensions:               https://bugs.php.net/fix.php?id=80018&r=nozend
MySQL Configuration Error:        https://bugs.php.net/fix.php?id=80018&r=mysqlcfg