Re: Found some incompatibilities

On Wed, Feb 18, 2004 at 11:51:21AM +0100, Andreas Streichardt wrote:
> HI!
> 
> I just upgraded to php 4.3.5 RC3 and wanted to know if our software works with 
> it (currently our software is developed under 4.2.2 - but we are engaging an 
> upgrade now ;) ). We also use a pretty old smarty version (1.3.1). I 
> discovered a few oddities and i don't really know if that's a bug or intented 
> (probably it is just our stupid smarty code):
> 
> {if $logo1 ne $baseurl."layout/pixel_t.gif" OR $logo3 ne 
> $baseurl."layout/pixel_t.gif"}
> 
> that worked pretty fine using 1.3.1 but using the current smarty it produces 
> parse errors .... i attached a simple patch which fixes that for me. I guess 
> you had a good reason to put these quotes in there but i don't have any idea 
> of the internal smarty code, so maybe that is really a bug? Would be nice to 
> hear if that is a bug. If it is not a bug in smarty we would have serious 
> trouble upgrading as we have thousands of these files ;)

The quotes there are intended and necessary. A better fix would be
adding the "."-operator to the list of allowed operators in
Smarty_Compiler::_compile_if_tag() .

I think this would be a useful addition anyway.
 
> Furthermore our config file had a size of 0 bytes...the behaviour of fread 
> seems to have changed since 4.2.2...i "fixed" that too...

Can you elaborate? I didn't encounter any problems with a
0-bytes-config-file and php-4.3.4 for example.

greetings
messju


> Regards,
> 
> 	Andreas Streichardt

-- 
Smarty Development Mailing List (http://smarty.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php