Re[6]: Incorrect newline counters
Dmitry Koteroff <[email protected]>
| Newsgroups | gmane.comp.php.smarty.devel |
|---|---|
| Message-ID | <[email protected]> |
DK>> B> [..snip..] DK>> What do you say about the example above? Do you use its DK>> side-effect in your templates? Doubtful. B> Yes, this is a known behaviour that is suboptimal. What do you B> expect I have done to-date? I expect nothing, of course. On the contrary - I offer to fix this by myself (later or soon), modifying and automatizing method which is used to generate compiled code (tags must not care about \n's and line sync at all, newlines are not their business). >> B> So unless you can present a series of well defined test-cases that >> show >> B> how your changes will have absolutely, gauranteed, no effect on >> the >> B> output, I can't see anyone supporting your changes. DK>> I'll do it, and I am ready to improve Smarty "space behavour" at DK>> all (together with line number synchronization), but I need DK>> sanctions. B> Well, in principle, that is a good thing. All I really ask is B> that you present your changes in a way that clearly shows how B> the behaviour will be modified (or prove that it won't be B> changed). Proposals of new behavour (eating leading whitespaces) are here: http://news.php.net/article.php?group=php.smarty.dev&article=2371 B> It appears that there is now some discussion and documentation B> occuring around that point and that is far more acceptable B> than a patch to a sensitive area that merely purports to be an B> improvement without providing even test cases let alone a B> thorough examination of the issues. We should reach agreement first about whitespace concept, and only after that write test cases. -- Best regards, Dmitry Koteroff. -- Smarty Development Mailing List (http://smarty.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php