Re: v2.6.3 and plugins with numeric strings in the plugin name

i committed a fix. please test.

greetings
messju



On Tue, Jun 29, 2004 at 10:05:10PM +0200, messju mohr wrote:
> Hi!
> 
> On Tue, Jun 29, 2004 at 08:46:03PM +0100, Mark West wrote:
> > Guys,
> > 
> > Having recently updated the PostNuke CVS to smarty v2.6.3 we're seeing an
> > issue with a couple of our custom plugins.
> > 
> > We use a visual editor (typetool) and have custom plugins named typetoolv80
> > and typetoolv55 (both do different things for the version of the editor in
> > use). Since upgrading to v.2.6.3 all we see is the name of plugin returned
> > for these plugins only - all other plugins work fine. The only difference
> > between these and our many other plugins is the numeric part of the name.
> > Editing the plugin to remove the numeric part of the plugin name returns the
> > plugin to normal functionality.
> > 
> > After a look at the changelog i'd  guess this is related to the change
> > "enhanced support of numeric constants as variable-expressions (messju)" but
> > i've not had chance to check this against the relevant cvs commits. I know
> > that replacing Smarty_Compiler.class.php with the version of v2.6.2 fixes
> > the problem.
> 
> you are correct. it seems this flaw was introduced with the change to
> allow numeric constants. i will look into that and try to provide a
> fix soon.
> 
> greetings
> messju
>  
> > I checked the docs in case we where using a invalid plugin name but the docs
> > (http://smarty.php.net/manual/en/plugins.naming.conventions.php) indicate
> > that our chosen plugin name is valid ("And name should be a valid identifier
> > (letters, numbers, and underscores only)." ).
> > 
> > I should add (since it's my first post to list ;)) good job on smarty...
> > We're about 85% of the way to making PostNuke a fully smarty-fied
> > application. An update to our existing product is already available to bring
> > the power of smarty to our development community.
> > 
> > Thanks.
> > 
> > -Mark
> > 
> > Mark West
> > Co-lead Developer
> > PostNuke
> > http://www.postnuke.com

-- 
Smarty Development Mailing List (http://smarty.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php