Re: [PATCH] use file_get_contents instead fread($fp, filesize($filename))
messju mohr <[email protected]>
| Newsgroups | gmane.comp.php.smarty.devel |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Jul 06, 2004 at 06:03:25PM +0400, Antony Dovgal wrote: > Hi! > > Small patch, which removes all fopen() - fread($fp, filesize($filename)) > - fclose() cases, replacing them with one file_get_contents() call. > > Moreover, this fixes problem with bug http://bugs.php.net/29023, which > prevents Smarty from working properly. > > Regardless of the fact that this bug will be fixed (I hope), this > fopen-fread-filesize-fclose mess can be safely replaced by one > file_get_contents() calls. > > Please, review it. i understand http://bugs.php.net/29023 in a way that the bug only occurs if not a larger read size is specified as the second parameter. smarty passes the filesize as second parameter and should work well, not? > --- > WBR, > Antony Dovgal aka tony2001 > [email protected] || [email protected] -- Smarty Development Mailing List (http://smarty.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php