Re: [patch] code cleanup

On Tue, May 29, 2007 at 08:50:17AM -0700, boots wrote:
> Hi.
> 
> You didn't mention exactly what your cleanup goals were. If it was consistency,
> you may have chose the existing prevalent style, but I suppose you intended to
> enforce a new style. FWIW, I'm not against style changes that differentiate
> keywords from invocations ie: if ($foo) instead of if($foo) and foo($bar)
> instead of foo ($bar). I don't care for putting whitespace around the
> assignment in function/method declarations ie: I personally prefer function
> foo($bar=0) rather than function foo($bar = 0). I noticed too that you added
> some docblocks but also that you modified (extended) the length of some
> existing comments. Aside from some trivial whitespacing, I couldn't notice any
> other changes in your patch. Did I miss any?
> 

Hi boots, thank you for your reply.

I'm surprised you thought I wanted to impose a new style, because actually I tried
to follow the prevalent style, i.e. single newline between methods, "if (" instead
of "if(", and so on. In fact my style would have been a little different from this.

> I should say that it is a pity that you mixed formatting changes with semantic
> actual code changes, particularly for a patch this size. You might consider
> reposting as separate patches as I don't think it is appropriate otherwise.
> 

Splitting the patch would require some time, so I'd like to first see some coding
rules formalized, if there are none yet. Did I miss it or you actually don't
have one?

The quickest way usually is just saying something like "Smarty follows PEAR coding
rules". In that case les jeux son fait, because my patch almost follows that rule.

http://pear.php.net/manual/en/standards.php

Regards

(quoting?)

-- 
Giovanni Giacobbi

-- 
Smarty Development Mailing List (http://smarty.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php