Re: [patch] code cleanup

On Tue, May 29, 2007 at 06:00:59PM +0200, messju mohr wrote:
> FWIW: I always tried to follow the rule:
> 
>    - whitespace between control-structure-keyword and condition
>    - no whitespace between function/method-name and argument list
> 
> so "if (..." is right and "if(..." is false.
> and "foo(..." is right and "foo (..." is false.
> 
> but I agree that it's not acceptable to mix whitespace-cleanups with
> changes in one huge patch.
> 

Please:

1) Run a script to trim trailing spaces
2) Search & replace "if(" with "if ("
3) Search & replace "else if" with "elseif"
4) Commit

(a few minutes work)

I'll then submit again two patches, one with the remainder of whitespace cleanup and one
with semantic changes (i won't get many conflicts for that commit).

> and I'm -1 on changing and/or touching {strip} in any way.
> 

Why not? Should I read the code again or it is really pointless that "if" statement?

Mine should be equivalent.

Thanks, regards

-- 
Giovanni Giacobbi

-- 
Smarty Development Mailing List (http://smarty.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php