Re: [patch] bringing Smarty unit tests to PHPunit 3

--MP_15KC=WSoS5=T_mhU1Dl6iFS
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi boots and Smarty developers,

In the regard of your invitation I just sending RTLizing patches
attached with this email. 

patches are for latest development version of
function.html_checkboxes.php and function.html_radios.php from CVS.

This is result of function.html_checkboxes.php.patch
http://screenshots.opensourceclub.org/html_chackboxes.png
and same for html_radios

I know you are busy and I know these patches are not important
important and the priority is very low, but may be you put these patches
in to the review queue.

If you need anything, to review this patch feel free to ask me.

Best Regards,
Armen

On Thu, 14 Jun 2007 00:49:00 -0700 (PDT)
boots <[email protected]> wrote:

> Hi Sebastian.
> 
> I just want to say thanks for all the patches -- even a quick glance
> gives the impression that you really care about your contributions. I
> must say that I don't recall seeing patches replete with
> multi-language doc changes -- very cool! It deserves mentioning that
> submitting discrete patch sets for separate dev issues is *very* much
> appreciated.
> 
> I'm unfortunately short on time these days. My goal is to try to
> review your patches (and other outstanding contributions) by the end
> of the month -- assuming no other dev gets to them. Please do feel
> free to ping back and give a reminder if there is no appropriate
> action. For myself, I do think that while the codebase is stable
> enough to weather delays, it is a crying shame that some very good
> contributions have gone unheeded for so long. For my small part (as
> an avid Smarty user) I really do appreciate all the contributions and
> I try to consider and follow up on each one as time permits. So, if
> anyone feels that they submitted patch recently but haven't had
> adequate feedback, please take this as an invitation to ping back.
> 
> One thing: I'm especially anxious to try out the PHPUnit3 changes. It
> is challenging for PHP4 users, but I tend to think it is a good idea.
> 
> Thanks again and I hope you see fit to continue your contributions in
> the future.
> 
> Best regards,
> boots
> 
> --- Sebastian Mendel <[email protected]> wrote:
> 
> > Sebastian Mendel schrieb:
> > > Hi,
> > > 
> > > this will update your unit testing suite to work with PHPunit 3
> > > 
> > > i also added some trim around Smarty returned values to remove
> > > trailing
> > line
> > > breaks -  as i don't think that this will do any harm
> > > 
> > > this makes smarty_unit_test.php and smarty_unit_test_gui.php
> > > obsolete
> > 
> > somehow it dropped the second attachment ...
> > 
> > 
> > -- 
> > Sebastian Mendel
> 
> 
> 
>  
> ____________________________________________________________________________________
> Finding fabulous fares is fun.  
> Let Yahoo! FareChase search your favorite travel sites to find flight
> and hotel bargains. http://farechase.yahoo.com/promo-generic-14795097
> 

--MP_15KC=WSoS5=T_mhU1Dl6iFS
Content-Type: text/x-patch; name=function.html_checkboxes.php.patch
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename=function.html_checkboxes.php.patch

Index: function.html_checkboxes.php
===================================================================
RCS file: /repository/smarty/libs/plugins/function.html_checkboxes.php,v
retrieving revision 1.20
diff -r1.20 function.html_checkboxes.php
24a25
>  *           - direction  (optional) - add direction for fields
51a53
>     $direction = 'ltr';
58a61
>             case 'direction':
107c110
<             $_html_result[] = smarty_function_html_checkboxes_output($name, $_key, $_val, $selected, $extra, $separator, $labels);
---
>             $_html_result[] = smarty_function_html_checkboxes_output($name, $_key, $_val, $selected, $extra, $separator, $labels, $direction);
113c116
<             $_html_result[] = smarty_function_html_checkboxes_output($name, $_key, $_val, $selected, $extra, $separator, $labels);
---
>             $_html_result[] = smarty_function_html_checkboxes_output($name, $_key, $_val, $selected, $extra, $separator, $labels, $direction);
126,128c129,133
< function smarty_function_html_checkboxes_output($name, $value, $output, $selected, $extra, $separator, $labels) {
<     $_output = '';
<     if ($labels) $_output .= '<label>';
---
> function smarty_function_html_checkboxes_output($name, $value, $output, $selected, $extra, $separator, $labels, $direction) {
>     $_output  = '';
>     $_output .= ($labels)?'<label dir="'.smarty_function_escape_special_chars($direction).'">':
>                           '<span dir="'.smarty_function_escape_special_chars($direction).'">';
> 
137,138c142,143
<     if ($labels) $_output .= '</label>';
<     $_output .=  $separator;
---
>     $_output .= ($labels)?'</label>':'</span>';
>     $_output .= $separator;

--MP_15KC=WSoS5=T_mhU1Dl6iFS
Content-Type: text/x-patch; name=function.html_radios.php.patch
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename=function.html_radios.php.patch

Index: function.html_radios.php
===================================================================
RCS file: /repository/smarty/libs/plugins/function.html_radios.php,v
retrieving revision 1.28
diff -r1.28 function.html_radios.php
24a25
>  *           - direction  (optional) - add direction for fields 
53a55
>     $direction = 'ltr';    
58a61
>             case 'direction':            
111c114
<             $_html_result[] = smarty_function_html_radios_output($name, $_key, $_val, $selected, $extra, $separator, $labels, $label_ids);
---
>             $_html_result[] = smarty_function_html_radios_output($name, $_key, $_val, $selected, $extra, $separator, $labels, $label_ids, $direction);
117c120
<             $_html_result[] = smarty_function_html_radios_output($name, $_key, $_val, $selected, $extra, $separator, $labels, $label_ids);
---
>             $_html_result[] = smarty_function_html_radios_output($name, $_key, $_val, $selected, $extra, $separator, $labels, $label_ids, $direction);
130c133,134
< function smarty_function_html_radios_output($name, $value, $output, $selected, $extra, $separator, $labels, $label_ids) {
---
> function smarty_function_html_radios_output($name, $value, $output, $selected, $extra, $separator, $labels, $label_ids, $direction) {
>     $_dir    = 'dir="'.smarty_function_escape_special_chars($direction).'"';
135c139
<           $_output .= '<label for="' . $_id . '">';
---
>           $_output .= '<label for="' . $_id . '" ' . $_dir . '>';
137c141
<           $_output .= '<label>';           
---
>           $_output .= '<label ' . $_dir . '>';           
138a143,144
>    } else {
>       $_output .= '<span ' . $_dir . '>';
150,151c156,157
<     if ($labels) $_output .= '</label>';
<     $_output .=  $separator;
---
>     $_output .= ($labels)?'</label>':'</span>';
>     $_output .= $separator;    


--MP_15KC=WSoS5=T_mhU1Dl6iFS
Content-Type: text/plain; charset=us-ascii

-- 
Smarty Development Mailing List (http://smarty.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
--MP_15KC=WSoS5=T_mhU1Dl6iFS--