a2ps-4.14 bug report

David Binderman <[email protected]> Mon, 12 Sep 2011 16:39:55 +0000

Newsgroups	gmane.comp.printing.a2ps.bugs
Message-ID	<[email protected]>

Hello there,

I recently tried out the cppcheck static analysis tool on the source
code of a2ps-4.14

It said

[a2ps-4.14/lib/signame.c:306]: (warning) Mutual exclusion over || always evaluates to true. Did you intend to use && instead?

The source code is

  if (signal > 0 || signal < NSIG)

More plausible code might be

  if (signal > 0 && signal < NSIG)

Regards

David Binderman