Fwd: fixed flaws in vba.ssh

--f46d044784e97ca32004ce76e9c0
Content-Type: text/plain; charset=ISO-8859-1

FYI

---------- Forwarded message ----------
From: Masayuki Hatta <[email protected]>
Date: 2012/11/15
Subject: Re: fixed flaws in vba.ssh
To: Stefan Seidler <[email protected]>


Hi Stefan,

Thanks for the fix.  I'm now preparing the next maintenance release of
a2ps, and your fix will definitely be included.

Best regards,
MH


2012/11/14 Stefan Seidler <[email protected]>

> Hi,
>
> I found two flaws in the Stylesheet for Visual Basic for Applications
> (vba.ssh) for a2ps.
> - ElseIf if misspelled so its not highlighted in the printout
> - missing comma in the keywords list so "Integer" is always printed as "Is"
>
> Below I have included the diff -u for patch. This includes the change
> suggested in http://lists.gnu.org/archive/**html/bug-a2ps/2009-07/**
> msg00000.html<http://lists.gnu.org/archive/html/bug-a2ps/2009-07/msg00000.html>as well.
>
> How can this be included into the next release?
>
> Best Regards,
>  Stefan
>
>
> --- vba.ssh     2012-11-14 13:46:30.892129632 +0100
> +++ vba.ssh_new 2012-11-14 13:46:14.891129423 +0100
> @@ -24,7 +24,7 @@
>
>  style "Visual Basic for Applications" is
>  written by "Dirk Eddelbuettel <[email protected]>"
> -version is 1.0
> +version is 1.1
>  requires a2ps 4.10
>
>  alphabets are
> @@ -37,9 +37,9 @@
>     CDate, CDbl, CDecl, CInt, Circle, CLng, Close, Const, CSng, CStr,
>     CurDirrase, Currency, CVar, CVDate, CVErr, Date, Debug, Declare,
>     DefBool, DefCur, DefDate, DefInt, DefObj, DefSng, DefStr, DefVar, Dim,
> -   Dir, Do, Double, Each, Else, Elself, Empty, End, EndIf, Eqv, Erase,
> +   Dir, Do, Double, Each, Else, ElseIf, Empty, End, EndIf, Eqv, Erase,
>     "Error", Exit, False, Fix, For, Format, FreeFile, Function, Get,
> Global,
> -   GoSub, GoTo, If, Imp, In, Input, InputB, Instr, InstrB, Int, Integer
> +   GoSub, GoTo, If, Imp, In, Input, InputB, Instr, InstrB, Int, Integer,
>     Is, LBound, Len, LenB, Let, Like, Line, Load, Local, Lock, Long, Loop,
>     LSet, Me, Mid, MidB, Mod, Name, New, Next, Not, Nothing, Null, Object,
>     On, Open, Option, Or, Point, Preserve, Print, Private, Property, PSet,
> @@ -66,7 +66,10 @@
>
>  sequences are
>      "'" Comment,
> -    C-string
> +    "\"" Plain String "\"" Plain
> +       exceptions are
> +          "\"\""
> +       end exceptions
>  end sequences
>
>  end style
>
>


-- 
Masayuki Hatta <mhatta at gmail.com>




-- 
Masayuki Hatta <mhatta at gmail.com>

--f46d044784e97ca32004ce76e9c0
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

FYI<br><br><div class=3D"gmail_quote">---------- Forwarded message --------=
--<br>From: <b class=3D"gmail_sendername">Masayuki Hatta</b> <span dir=3D"l=
tr">&lt;<a href=3D"mailto:[email protected]">[email protected]</a>&gt;</span>=
<br>Date: 2012/11/15<br>
Subject: Re: fixed flaws in vba.ssh<br>To: Stefan Seidler &lt;<a href=3D"ma=
ilto:[email protected]">[email protected]</a>&gt;<br><br><br>Hi Stefan,<br><br>Thanks=
 for the fix.=A0 I&#39;m now preparing the next maintenance release of a2ps=
, and your fix will definitely be included.<br>
<br>Best regards,<br>MH<br><div class=3D"gmail_extra"><div><div class=3D"h5=
"><br><br><div class=3D"gmail_quote">
2012/11/14 Stefan Seidler <span dir=3D"ltr">&lt;<a href=3D"mailto:sseid@web=
.de" target=3D"_blank">[email protected]</a>&gt;</span><br><blockquote class=3D"=
gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-=
left:1ex">

Hi,<br>
<br>
I found two flaws in the Stylesheet for Visual Basic for Applications (vba.=
ssh) for a2ps.<br>
- ElseIf if misspelled so its not highlighted in the printout<br>
- missing comma in the keywords list so &quot;Integer&quot; is always print=
ed as &quot;Is&quot;<br>
<br>
Below I have included the diff -u for patch. This includes the change sugge=
sted in <a href=3D"http://lists.gnu.org/archive/html/bug-a2ps/2009-07/msg00=
000.html" target=3D"_blank">http://lists.gnu.org/archive/<u></u>html/bug-a2=
ps/2009-07/<u></u>msg00000.html</a> as well.<br>


<br>
How can this be included into the next release?<br>
<br>
Best Regards,<br>
=A0Stefan<br>
<br>
<br>
--- vba.ssh =A0 =A0 2012-11-14 13:46:30.892129632 +0100<br>
+++ vba.ssh_new 2012-11-14 13:46:14.891129423 +0100<br>
@@ -24,7 +24,7 @@<br>
<br>
=A0style &quot;Visual Basic for Applications&quot; is<br>
=A0written by &quot;Dirk Eddelbuettel &lt;<a href=3D"mailto:[email protected]"=
 target=3D"_blank">[email protected]</a>&gt;&quot;<br>
-version is 1.0<br>
+version is 1.1<br>
=A0requires a2ps 4.10<br>
<br>
=A0alphabets are<br>
@@ -37,9 +37,9 @@<br>
=A0 =A0 CDate, CDbl, CDecl, CInt, Circle, CLng, Close, Const, CSng, CStr,<b=
r>
=A0 =A0 CurDirrase, Currency, CVar, CVDate, CVErr, Date, Debug, Declare,<br=
>
=A0 =A0 DefBool, DefCur, DefDate, DefInt, DefObj, DefSng, DefStr, DefVar, D=
im,<br>
- =A0 Dir, Do, Double, Each, Else, Elself, Empty, End, EndIf, Eqv, Erase,<b=
r>
+ =A0 Dir, Do, Double, Each, Else, ElseIf, Empty, End, EndIf, Eqv, Erase,<b=
r>
=A0 =A0 &quot;Error&quot;, Exit, False, Fix, For, Format, FreeFile, Functio=
n, Get, Global,<br>
- =A0 GoSub, GoTo, If, Imp, In, Input, InputB, Instr, InstrB, Int, Integer<=
br>
+ =A0 GoSub, GoTo, If, Imp, In, Input, InputB, Instr, InstrB, Int, Integer,=
<br>
=A0 =A0 Is, LBound, Len, LenB, Let, Like, Line, Load, Local, Lock, Long, Lo=
op,<br>
=A0 =A0 LSet, Me, Mid, MidB, Mod, Name, New, Next, Not, Nothing, Null, Obje=
ct,<br>
=A0 =A0 On, Open, Option, Or, Point, Preserve, Print, Private, Property, PS=
et,<br>
@@ -66,7 +66,10 @@<br>
<br>
=A0sequences are<br>
=A0 =A0 =A0&quot;&#39;&quot; Comment,<br>
- =A0 =A0C-string<br>
+ =A0 =A0&quot;\&quot;&quot; Plain String &quot;\&quot;&quot; Plain<br>
+ =A0 =A0 =A0 exceptions are<br>
+ =A0 =A0 =A0 =A0 =A0&quot;\&quot;\&quot;&quot;<br>
+ =A0 =A0 =A0 end exceptions<br>
=A0end sequences<br>
<br>
=A0end style<br>
<br>
</blockquote></div><br><br clear=3D"all"><br></div></div><span class=3D"HOE=
nZb"><font color=3D"#888888">-- <br>Masayuki Hatta &lt;mhatta at <a href=3D=
"http://gmail.com" target=3D"_blank">gmail.com</a>&gt;<br><br>
</font></span></div>
</div><br><br clear=3D"all"><br>-- <br>Masayuki Hatta &lt;mhatta at <a href=
=3D"http://gmail.com">gmail.com</a>&gt;<br><br>

--f46d044784e97ca32004ce76e9c0--