[LOW] STR #4067: Dead code in ipp_read_http()?

Edgar Fu?? <ef-o02PS0xoJP/[email protected]>
Newsgroups gmane.comp.printing.cups.bugs
Message-ID <[email protected]>
DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR New]

I think there is dead code in ipp_read_http().

At cups/ipp.c:3146, there is a
    if (http->data_encoding == HTTP_ENCODE_CHUNKED)
clause that is itself wrapped inside a
    if (http->used > 0 && http->data_encoding == HTTP_ENCODE_LENGTH)
at cups/ipp.c:3117.
I cannot see how http->data_encoding may change in between other than a
memcpy() or memmove() going wild.

There's also a
    if (http->data_encoding != HTTP_ENCODE_CHUNKED)
at line 3156 that seems redundant.

Or what am I missing?

Link: http://www.cups.org/str.php?L4067
Version: 1.5.2
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.