[cups-devel] [UNKN] STR #4744: FINAL_CONTENT_TYPE set incorrectly when no filters

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR New]

FINAL_CONTENT_TYPE is set incorrectly when no filters are needed. Reading
the code this seems to have been broken by r11147 which dates all the way
back from 1.7.0.

That commit added a fallback to set FINAL_CONTENT_TYPE to "printer/<name>"
when no other content type was found. It references
<rdar://problem/14355011>, so I don't know exactly what problem it is
trying to solve.

The short description is however that FINAL_CONTENT_TYPE was missing, which
was indeed the behaviour before 1.7.0. But I think this fix is wrong
because it means that FINAL_CONTENT_TYPE now no longer contains the actual
content type of the data, in stark contrast to when filters are actually
involved.

I think the proper fix is simply to use the incoming content type, which is
the correct type since no filters were involved so the data never changed.

Link: https://www.cups.org/str.php?L4744
Version: 1.7.0
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: GPGTools - https://gpgtools.org

iQIcBAEBCgAGBQJWaD+6AAoJENujp6sI12IjARwQAIszh0bLxzf95OdHQ0Y569Qb
vztuV4f1IHZzLl3uutdyNtsz6lc3F/z81rmIrEa7vvgZPjkxjpC4PouGmSocUl2t
3QldbGOuNznTL9LTqsK5iGQ7YkQAjZwZiW9RLDtdCc6sl2yWCOKA8FEVnjQHYR0I
6mMkTKIRd0P9H25PlX8+MWwPZPj/EHbLWXpOS94yeHLIeA4wuhQUPwumqOOFYPIQ
IZYWwmRpO8WWBkmiiF7PdhO1fSiLM+9rz1UUsi8eH/N6hS3AQfFTOtxmpC9No0/2
DyO5KhtVb7ZkDy08Neqip7tllijLS0fCCgAh6z+UZpW4RpGggqHj46/PQCr7If05
dBRHC3SiA+i4EbiLmGNq9xVtbyWF6LxpdyQ2xONWqo9Sra66iUtZM2stCDv76FWe
4J44IJSOFv/CXJBQwniwdFI2SWHtvTG1swzUYUanS4t1vIWXCpNdPdYAtJxNMGCh
lzYQYm7QySzz30X/oJ8JspioATme1vL1MsQcE+YDubb1nKswHWXkLVgME5/bbugi
XQB0T5nfkHGRIQ82bRRAk/rg/dLXw1rV8uuevRqWg72pwl5KXJSst2I+QP69WBl6
zWCJNnd+ZXHvhRBdiufNboJJPxiMcKHgvtk4N+cYMqjLDHBzOA5lWa9OD2+SIt67
Jyk9sRaDPYhrwkG2vIEQ
=V2DM
-----END PGP SIGNATURE-----