[gs-commits] ghostpdl branch, master, updated. jbig2dec-0.14-1708-g7db398d

[email protected] (Chris Liddell) Thu, 26 Sep 2019 09:48:22 +0000 (UTC)
Newsgroups gmane.comp.printing.ghostscript.cvs
Message-ID <[email protected]>
The ghostpdl branch, master has been updated
       via  7db398d549a03ff5d37ec991eb60f01378eac88d (commit)
      from  8992f00edfd1c39154c013489de2a01d2e9a92ee (commit)

----------------------------------------------------------------------
commit 7db398d549a03ff5d37ec991eb60f01378eac88d
Author: Chris Liddell <[email protected]>
Date:   Thu Sep 26 10:47:01 2019 +0100

    Revised comment for 8992f00edfd1c39154c013489de2a01d2e9a92ee
    
    Make it clearer why the revised behaviour is required.

diff --git a/base/gstiffio.c b/base/gstiffio.c
index a99e5e7..6828a61 100644
--- a/base/gstiffio.c
+++ b/base/gstiffio.c
@@ -212,9 +212,11 @@ gs_tifsErrorHandlerEx(thandle_t client_data, const char* module, const char* fmt
 
 void tiff_set_handlers (void)
 {
-    /* Bad things happen if multiple callers are using libtiff
-     * with custom error/warning callbacks, so set them to NULL
-     * if we're using a libtiff shared lib
+    /* Bad things happen if we set custom error/warning
+     * handlers, and multiple callers are using the shared
+     * libtiff - our handlers may be triggered in the
+     * context of the other caller(s) meaning it's not
+     * our client_data being passed in.
      */
     (void)TIFFSetErrorHandler(NULL);
     (void)TIFFSetWarningHandler(NULL);


Summary of changes:
 base/gstiffio.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)