Re: Ghostscript/GhostPDL 9.23 Release Candidate 1

Hi,

I just realised I'd forgotten to reply - sorry.

On 15/03/18 10:40, Johannes Meixner wrote:
> 
> Hello,
> 
> On Mar 14 10:10 Johannes Meixner wrote (excerpt):
>> I need the patch below to make it with non-root target directory
> 
> Meanwhile I use a simpler patch
> (long lines may show wrappped here):
> ---------------------------------------------------------------------
> --- base/unixinst.mak.orig      2018-03-07 16:01:52.000000000 +0100
> +++ base/unixinst.mak   2018-03-12 14:06:43.000000000 +0100
> @@ -163,7 +163,7 @@ install-doc: $(PSDOCDIR)/News.htm
>         $(SH) -c 'for f in $(DOC_PAGES) ;\
>         do if ( test -f $(PSDOCDIR)/$$f ); then $(INSTALL_DATA)
> $(PSDOCDIR)/$$f $(DESTDIR)$(docdir); fi;\
>         done'
> -       ln -s $(DESTDIR)$(docdir) $(gsdatadir)/doc
> +       # ln -s $(DESTDIR)$(docdir) $(gsdatadir)/doc
> 
>  # install the man pages for each locale
>  MAN_LCDIRS=. de
> ---------------------------------------------------------------------
> because I do not need that link because
> in our openSUSE ghostscript RPM we always had and still have
> a link from SUSE's and openSUSE's usual documentation
> directory /usr/share/doc/packages/ like this:
> /usr/share/doc/packages/ghostscript -> ../ghostscript/9.23

I'm going with your first patch. The original change was made to move
the Ghostscript docs to be more in-line with the current layout of
documentation the distros are using, but I also wanted to avoid being
confusing for existing users who would likely dive straight for the old
location.

We will almost certainly remove the link in a (near) future release.


> Furthermore I think since ghostscript-9.23rc1 the examples
> in the source directories examples/ and in examples/cjk
> are no longer installed by default.

Yes, there's really no point installing them - they are handy for a
quick smoke test when building a binary (hence still including them in
the release archive), but they are of no real use to end users.

> Finally since ghostscript-9.23rc1 I get a compilation error
> only on the s390x architecture (which exists only in SLES12)
> but I did not yet investigate what the root cause might be
> (long lines may show wrappped here):
> ----------------------------------------------------------------------
> ./lcms2art/src/cmsmd5.c: In function 'byteReverse':
> ./lcms2art/src/cmsmd5.c:36:51: error: 'ContextID' undeclared (first use
> in this function)
>          cmsUInt32Number t = _cmsAdjustEndianess32(ContextID,
> *(cmsUInt32Number *) buf);
>                                                    ^
> ./lcms2art/src/cmsmd5.c:36:51: note: each undeclared identifier is
> reported only once for each function it appears in
> base/lcms2art.mak:134: recipe for target 'soobj/cmsmd5.o' failed
> make[2]: *** [soobj/cmsmd5.o] Error 1
> ----------------------------------------------------------------------

Thanks for spotting that, we fixed it:
http://git.ghostscript.com/?p=ghostpdl.git;a=commitdiff;h=124b37fc65f


I should point out that for a distribution package, you probably don't
want to be building the lcms2art code (the beginning of a lcms2 fork -
see News.htm in the release archive). But almost certainly you want to
remove the lcms2art directory.

Chris