Re: Fix for 687010: incorrect annot flag value

Fine with me.

Igor.

----- Original Message ----- 
From: "Raph Levien" <[email protected]>
To: <[email protected]>
Sent: Thursday, August 21, 2003 9:59 PM
Subject: [gs-code-review] Fix for 687010: incorrect annot flag value


> Fix decimal value of "NoView" annotation flag in annotvisible logic.
> Fixes bug #687010.
> 
> DETAILS:
> 
> On page 493 of the PDF 1.4 reference, NoView is specified as bit
> position 6, which would seem to correspond to the old value of 64.
> However, for some reason Adobe counts its bit positions starting at
> 1, so the actual numeric value is 2^(bit pos - 1), or 32.
> 
> Index: lib/pdf_draw.ps
> ===================================================================
> RCS file: /cvs/ghostscript/gs/lib/pdf_draw.ps,v
> retrieving revision 1.73
> diff -C2 -r1.73 pdf_draw.ps
> *** lib/pdf_draw.ps 23 Jul 2003 21:27:48 -0000 1.73
> --- lib/pdf_draw.ps 21 Aug 2003 17:54:59 -0000
> ***************
> *** 1178,1182 ****
>     dup 2 and 0 eq  % Check hidden flag
>     exch dup 4 and 0 ne Printed and % Check print flag
> !   exch 64 and 0 eq Printed not and % Check noview flag
>     or % Combine print and view
>     and % Combine with 'hidden' flag test
> --- 1178,1182 ----
>     dup 2 and 0 eq  % Check hidden flag
>     exch dup 4 and 0 ne Printed and % Check print flag
> !   exch 32 and 0 eq Printed not and % Check noview flag
>     or % Combine print and view
>     and % Combine with 'hidden' flag test
> _______________________________________________
> gs-code-review mailing list
> [email protected]
> http://www.ghostscript.com/mailman/listinfo/gs-code-review
>