RE: CGM driver update

Ralph,

I think that the variable which you added called 'blank' should be
called 'white'.  The name 'blank' would be more appropriate for
something like the pngalpha device that has a transparent background.
This does not seem to be the case with the CGM devices since they
are using default color mapping routines.  Note:  Either 1 or 3 of 
the variables values will be used depending on if the CGM device is
monochrome or RGB.  (There are a monochrome and two RGB versions of
the CGM device.)

I do not know that the cdev->in_picture flag is actually supposed to
do.  Your change does correctly convert from the old map_rgb_color
routine to the new encode_color routine.


Dan


-----Original Message-----
From: Ralph Giles [mailto:[email protected]]On Behalf Of Ralph Giles
Sent: Wednesday, October 22, 2003 5:41 AM
To: [email protected]; [email protected]
Subject: CGM driver update


Dan,

If you wouldn't mind, I'd like review on the color mapping modernization 
patch I committed to the CGM driver:

  http://www.ghostscript.com/pipermail/gs-cvs/2003-October/003698.html

The whole idea of the code seems a little dubious, actually. Comments 
welcome.

There's another problem I'm stuck on: gs dies with '/undefined in get' 
which I use the cgm devices with tiger.eps or golfer.eps. It completes 
without error for alphabet.ps, waterfall.ps, colorcirc.ps, and 
escher.ps, so it seems to be related to eps parsing?

I also don't have a viewer for CGM files, so I can't verify it's 
producing correct images when it does complete. I'd appreciate is 
someone (Alex?) could verify that as well.

Cheers,
 -r