Tabs versus spaces in makefiles

"Dan Coby" <[email protected]>
Newsgroups gmane.comp.printing.ghostscript.patches
Message-ID <[email protected]>
The original specification for 'make' required a tab at the beginning
of each line of the body of a rule.  Most versions of 'make' no longer
have this requirement but there are some exceptions.  We just received
a comment about this from a customer.

I did a quick scan of our make files.  The only places that this
occurs are in msvc32.mak, msvclib.mak, msvctail.mak, and unixansi.mak.
The MSVC nmake does not care about tabs versus spaces.  The spaces
in unixansi.mak are a problem for some versions of make.

Below is a list of the specific locations.  Also included in this list
are 'blank' lines that really consist of one or more spaces.  I remember
a very stupid version of make that complained about this.  However that
was over a decade and a half ago.

I can easily commit these changes.  However I do not have the ability
to test on a variety of systems.

What should I do:
1.  Only commit the unixansi.mak change
2.  Only commit the unixansi.mak and the msvc*.mak changes
3.  Commit all of the changes.
4.  Go on to something useful.


Dan



Index: src/bcwin32.mak
===================================================================
RCS file: /cvs/ghostscript/gs/src/bcwin32.mak,v
retrieving revision 1.29
diff -r1.29 bcwin32.mak
160c160
<
---
>
Index: src/dvx-gcc.mak
===================================================================
RCS file: /cvs/ghostscript/gs/src/dvx-gcc.mak,v
retrieving revision 1.23
diff -r1.23 dvx-gcc.mak
164c164
<
---
>
Index: src/macos-mcp.mak
===================================================================
RCS file: /cvs/ghostscript/gs/src/macos-mcp.mak,v
retrieving revision 1.22
diff -r1.22 macos-mcp.mak
138c138
<
---
>
Index: src/macosx.mak
===================================================================
RCS file: /cvs/ghostscript/gs/src/macosx.mak,v
retrieving revision 1.20
diff -r1.20 macosx.mak
192c192
<
---
>
Index: src/msvc32.mak
===================================================================
RCS file: /cvs/ghostscript/gs/src/msvc32.mak,v
retrieving revision 1.49
diff -r1.49 msvc32.mak
612c612
<        	echo /DEF:$(PSSRCDIR)\dwmain32.def /OUT:$(GS_XE) >
$(PSGEN)gswin32.rsp
---
> 	echo /DEF:$(PSSRCDIR)\dwmain32.def /OUT:$(GS_XE) > $(PSGEN)gswin32.rsp
Index: src/msvclib.mak
===================================================================
RCS file: /cvs/ghostscript/gs/src/msvclib.mak,v
retrieving revision 1.24
diff -r1.24 msvclib.mak
489c489
<         $(SETMOD) $(GLGEN)mslib32_ $(mslib32__)
---
> 	$(SETMOD) $(GLGEN)mslib32_ $(mslib32__)
502c502
<         $(LINK) $(LCT) @$(GLGENDIR)\gslib32.rsp $(GLOBJ)gslib
@$(GLGENDIR)\gslib32.tr @$(LIBCTR) $(INTASM) @$(GLGENDIR)\lib.tr
---
> 	$(LINK) $(LCT) @$(GLGENDIR)\gslib32.rsp $(GLOBJ)gslib
@$(GLGENDIR)\gslib32.tr @$(LIBCTR) $(INTASM) @$(GLGENDIR)\lib.tr
Index: src/msvctail.mak
===================================================================
RCS file: /cvs/ghostscript/gs/src/msvctail.mak,v
retrieving revision 1.9
diff -r1.9 msvctail.mak
67,71c67,71
<         echo shell32.lib >$(LIBCTR)
<         echo comdlg32.lib >>$(LIBCTR)
<         echo gdi32.lib >>$(LIBCTR)
<         echo user32.lib >>$(LIBCTR)
<         echo winspool.lib >>$(LIBCTR)
---
> 	echo shell32.lib >$(LIBCTR)
> 	echo comdlg32.lib >>$(LIBCTR)
> 	echo gdi32.lib >>$(LIBCTR)
> 	echo user32.lib >>$(LIBCTR)
> 	echo winspool.lib >>$(LIBCTR)
Index: src/openvms.mak
===================================================================
RCS file: /cvs/ghostscript/gs/src/openvms.mak,v
retrieving revision 1.32
diff -r1.32 openvms.mak
155c155
<
---
>
353c353
<
---
>
Index: src/os2.mak
===================================================================
RCS file: /cvs/ghostscript/gs/src/os2.mak,v
retrieving revision 1.34
diff -r1.34 os2.mak
159c159
<
---
>
402c402
<
---
>
Index: src/ugcclib.mak
===================================================================
RCS file: /cvs/ghostscript/gs/src/ugcclib.mak,v
retrieving revision 1.25
diff -r1.25 ugcclib.mak
72c72
<
---
>
Index: src/unixansi.mak
===================================================================
RCS file: /cvs/ghostscript/gs/src/unixansi.mak,v
retrieving revision 1.32
diff -r1.32 unixansi.mak
179c179
<
---
>
413c413
<         -$(RM) Makefile
---
> 	-$(RM) Makefile
416c416
<         # nothing special to do
---
> 	# nothing special to do
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.