Re: Fix for 686815, Typo in source leads to failure of form selection for PCL printers

Alex,

I agree that it would be nice to patch this, but I checked the
PCL Technical Reference Manual and confirm that <ESC>&l%dA is
the syntax to set the page size.

Please commit.

Regards,
Ray
______________________________________________________________________

Alex Cherepanov wrote:

> Correct a typo in source leading to failure of form selection for PCL
> printers. (contributed by Jim Bandy)
> Fix bug 686815
> 
> This is a patch from the user adapted for our bug processing
> practice. Although the user has done everything (identified the
> problem and solved it), the bug has not been closed for 6
> month.
> 
> I cannot test this patch but:
> (1) I'm inclined to trust the user
> (2) The proposed PCL command "\033&l%dA" is used elsewhere in the
>     file for the same purpose: set the page size.
> 
> 
> ------------------------------------------------------------------------
> 
> Index: gs/src/gdevdljm.c
> ===================================================================
> RCS file: /cvs/ghostscript/gs/src/gdevdljm.c,v
> retrieving revision 1.8
> diff -b -u -r1.8 gdevdljm.c
> --- gs/src/gdevdljm.c	7 Oct 2002 08:28:56 -0000	1.8
> +++ gs/src/gdevdljm.c	29 Oct 2003 22:52:42 -0000
> @@ -144,7 +144,7 @@
>      fputs(page_init, prn_stream);
>      fprintf(prn_stream, "\033&l%dX", num_copies);	/* # of copies */
>      if (features & PCL_CAN_SET_PAPER_SIZE){ 
> -        fprintf(prn_stream, "\033&|%dA", paper_size); 
> +        fprintf(prn_stream, "\033&l%dA", paper_size); 
>      } 
>  
>      /* End raster graphics, position cursor at top. */
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> gs-code-review mailing list
> [email protected]
> http://www.ghostscript.com/mailman/listinfo/gs-code-review