Re: Re: [gs-cvs] gs/lib

Ray,

> From: "Ray Johnston" <[email protected]>
> To: "Igor V. Melichev" <[email protected]>
> Cc: <[email protected]>; "Ray Johnston" <[email protected]>
> Sent: Friday, November 14, 2003 6:47 PM
> Subject: Re: [gs-code-review] Re: [gs-cvs] gs/lib


> Igor,
>
> Refer to: http://bugs.ghostscript.com/show_bug.cgi?id=687136
>
> As I wrote in the follow up to the bug when I closed it:
>
> "Since the PDF interpreter always seems to retain a 'currentpoint',
> the path may consists of only that point. Detect this by the
> case where pathbbox shows a net zero area."

Pitty that you missed it in the log message.
It comes to me after I've sent my message.

Now I've tested the patch and detected a regression with 031-05.ps .
The generated PDF file contains

q
0 0 m
W n
q
10 0 0 10 0 0 cm BT
/R12 10.9 Tf
1 0 0 1 202.124 178 Tm
(Genoa Technology Genoa Technology )Tj
ET
Q
Q

and the text must not be painted.

I would very appreciate if you test patches before commitment.
Attaching a simple script (maybe paths to be edited in there) :

diff-all.bat - compares two revisions with all tests
imdiff.bat - computes a raster difference for a specific test

others are subroutines, but compr.bat may be used for running a single test.
On my comp with -r72 it takes 25 minutes to run all comparefiles with
pdfwrite.
Alex uses it also.

> Thus the '{currentpoint pop pop} stopped' method will not work.

It depends on what moment to compute it.
Probably It won't in the place you patched.

Igor.

_______________________________________________
gs-code-review mailing list
[email protected]
http://www.ghostscript.com/mailman/listinfo/gs-code-review