Re: Partial fix for 587029, Different results on Alpha

Alex,

The change to gs_ttf.pf is fine due to TT spec.
However the log message is too general.
Please narrow it to the specific change.
The general problem to be posted to gs-devel.

Igor.

----- Original Message ----- 
From: "Alex Cherepanov" <[email protected]>
To: "gs-code-review" <[email protected]>
Sent: Saturday, November 15, 2003 10:00 AM
Subject: [gs-code-review] Partial fix for 587029, Different results on Alpha


> Do sign extension on 64-bit platforms.
>
> Genoa test considers 64-bit integers to be an error. If we decide
> to implement 32-bit arithmetic on any platform this patch
> should be undone.
>


----------------------------------------------------------------------------
----


> Index: gs/lib/gs_ttf.ps
> ===================================================================
> RCS file: /cvs/ghostscript/gs/lib/gs_ttf.ps,v
> retrieving revision 1.33
> diff -b -u -r1.33 gs_ttf.ps
> --- gs/lib/gs_ttf.ps 15 Oct 2003 00:03:30 -0000 1.33
> +++ gs/lib/gs_ttf.ps 15 Nov 2003 06:51:39 -0000
> @@ -192,6 +192,13 @@
>    2 copy gets16 16 bitshift 3 1 roll 2 add getu16 add
>  } bind def
>
> +16#ffffffff 0 gt {  % 64-bit sign extension
> +  { /curxuid /gets32 } {
> +    mark 1 index load aload pop { 16#80000000 xor 16#80000000 sub } aload
pop
> +    .packtomark cvx def
> +  } bind forall
> +} if
> +
>  % <string> <index> <integer> putu16 -
>  /putu16 {
>    3 copy -8 bitshift put
>


----------------------------------------------------------------------------
----


> _______________________________________________
> gs-code-review mailing list
> [email protected]
> http://www.ghostscript.com/mailman/listinfo/gs-code-review
>