RE: PDF 1.5 parser Changes.

Igor,

>But reading the log message I've got some misunderstanding
>of the patch's purpose and the algorithm.

The purpose of the 'patch' is to implement two new features
of PDF which are included in the PDF 1.5 specification.  These
features are object streams and compressed XRef tables.
This was described in the release message.


>In the past Dan implemented
>a workaround for mangled PDFs with a bad xref.
>I would like to get an explanation how the new stuff interacts
>with the old workaround. IMO the log message must explain that.

I only have one test file for these new features.  It is not
damaged.  Thus there has been no testing.  

Compressed object streams are a new situation.  Objects
inside of compressed object streams will not be detected.  Thus
the rebuild logic would fail with files that contain object
streams.  However since these are generally compressed into
binary data which will probably be mangled and thus unreadable,
I doubt that Adobe be able to recover a file which contains
compressed object streams.  I do not think that we should
consider putting any effort into the XRef rebuild logic for
compressed object streams unless we see some sign that Adobe
can rebuild these files.


Dan


-----Original Message-----
From: Igor V. Melichev [mailto:[email protected]]
Sent: Wednesday, December 10, 2003 4:35 AM
To: [email protected]
Cc: Ray Johnston; tech
Subject: Re: [gs-code-review] PDF 1.5 parser Changes.


Dan,

Rather I'm an official reviewer of Dan's patches
(I believe it is still so, right ?),
I'm not a good reviewer of this stuff,
which is Ray's area. I would ask Ray for reviewing it.

But reading the log message I've got some misunderstanding
of the patch's purpose and the algorithm. 
In the past Dan implemented
a workaround for mangled PDFs with a bad xref.
I would like to get an explanation how the new stuff interacts
with the old workaround. IMO the log message must explain that.

Igor.


----- Original Message ----- 
From: "Dan Coby" <[email protected]>
To: "Gs-Code-Review" <[email protected]>
Sent: Wednesday, December 10, 2003 3:52 AM
Subject: [gs-code-review] PDF 1.5 parser Changes.
[...]