Re: Fix for 687059, Re-building a ready gswin32.exe

Alex,

Nice to hear that you found out the reason of the problem.
Thank you.

However I'm unhappy with 'copy' tricks used to resolve it,
as well ia in other (old) places in makefiles.
Can we avoid the with replacing

$(ld_tr) $(GLGENDIR)$(D)lib.tr : $(gconfig_h)
     $(NO_OP)

with

$(ld_tr) : $(gconfig_h)
    <commands to generate ld.tr>

$(GLGENDIR)$(D)lib.tr : $(gconfig_h)
    <commands to generate lib.tr>

?

Igor.



----- Original Message ----- 
From: "Alex Cherepanov" <[email protected]>
To: "gs-code-review" <[email protected]>
Sent: Friday, December 12, 2003 10:36 PM
Subject: [gs-code-review] Fix for 687059, Re-building a ready gswin32.exe


> LOG MESSAHE:
> Copy lib.tr and ld.tr as the last step to guarantee that they have later
> modification date than $(gconfig_h).
>
>
> DICSUSSION:
>
> There is another approach:
>
> $(ld_tr) $(GLGENDIR)$(D)lib.tr : $(gconfig_h)
> touch $@
>
> Unfortunately, some platforms don't have touch .
> So I'm copying the files instead touch-ing them.
> echogs is used because system copying utility may preserve file
> attributes, including the modification date.
>
> Intermediate files are not deleted because they can help
> debugging the build process, but I'm flexible in this
> respect.
>
>
>


----------------------------------------------------------------------------
----


> Index: gs/src/gs.mak
> ===================================================================
> RCS file: /cvs/ghostscript/gs/src/gs.mak,v
> retrieving revision 1.23
> diff -b -u -r1.23 gs.mak
> --- gs/src/gs.mak 11 Dec 2003 02:22:11 -0000 1.23
> +++ gs/src/gs.mak 12 Dec 2003 18:53:42 -0000
> @@ -272,6 +272,7 @@
>   $(RMN_) $(GSGEN)*.dev $(GSGEN)devs*.tr $(GSGEN)gconfig*.h
>   $(RMN_) $(GSGEN)gconfx*.h $(GSGEN)j*.h
>   $(RMN_) $(GSGEN)c*.tr $(GSGEN)o*.tr $(GSGEN)l*.tr
> + $(RMN_) $(GSGEN)l*.tmp
>
>  # Macros for constructing the *.dev files that describe features and
>  # devices.
> @@ -395,9 +396,10 @@
>  GCONFIG_EXTRAS=
>
>  ld_tr=$(GLGENDIR)$(D)ld.tr
> +ld_tmp=$(GLGENDIR)$(D)ld.tmp
>  $(gconfig_h) : \
>    $(GS_MAK) $(TOP_MAKEFILES) $(GLSRCDIR)$(D)version.mak $(GENCONF_XE)
$(ECHOGS_XE) $(devs_tr) $(DEVS_ALL) $(GLGENDIR)$(D)libcore.dev
> - $(EXP)$(GENCONF_XE) $(devs_tr) -h $(gconfig_h) $(CONFILES) $(CONFLDTR)
$(ld_tr)
> + $(EXP)$(GENCONF_XE) $(devs_tr) -h $(gconfig_h) $(CONFILES) $(CONFLDTR)
$(ld_tmp)
>   $(EXP)$(ECHOGS_XE) -a $(gconfig_h) -x 23 define -s -u GS_LIB_DEFAULT -x
2022 $(GS_LIB_DEFAULT) -x 22
>   $(EXP)$(ECHOGS_XE) -a $(gconfig_h) -x 23 define -s -u
SEARCH_HERE_FIRST -s $(SEARCH_HERE_FIRST)
>   $(EXP)$(ECHOGS_XE) -a $(gconfig_h) -x 23 define -s -u GS_DOCDIR -x 2022
$(GS_DOCDIR) -x 22
> @@ -405,10 +407,12 @@
>   $(EXP)$(ECHOGS_XE) -a $(gconfig_h) -x 23 define -s -u GS_REVISION -s
$(GS_REVISION)
>   $(EXP)$(ECHOGS_XE) -a $(gconfig_h) -x 23 define -s -u GS_REVISIONDATE -s
$(GS_REVISIONDATE)
>   $(EXP)$(ECHOGS_XE) -a $(gconfig_h) $(GCONFIG_EXTRAS)
> + $(EXP)$(ECHOGS_XE) -w $(ld_tr) -n -R $(ld_tmp)
> + $(EXP)$(ECHOGS_XE) -w $(GLGENDIR)$(D)lib.tmp -n -R $(GLGENDIR)$(D)lib.tr
> + $(EXP)$(ECHOGS_XE) -w $(GLGENDIR)$(D)lib.tr -n -R $(GLGENDIR)$(D)lib.tmp
>
>  $(ld_tr) $(GLGENDIR)$(D)lib.tr : $(gconfig_h)
> -
> -# The line above is an empty command; don't delete.
> + $(NO_OP)
>
>  obj_tr=$(GLGENDIR)$(D)obj.tr
>  $(obj_tr) : $(ld_tr)
>


----------------------------------------------------------------------------
----


> _______________________________________________
> gs-code-review mailing list
> [email protected]
> http://www.ghostscript.com/mailman/listinfo/gs-code-review
>