Re: Fix for 687349 A wrong comment forgx_device_color_s

Dan,

I would rewrite the second comment :

/*
 * 'ccolor' (a "client color") is valid iff 'ccolor_valid' is true.
 * For non-pattern colors, it contains the original paint values.
 * For pattern colors, it contains information required for remapping the pattern.
 */

When I opened the bug, I did not verify whether other comments
didn't become obsolete. It would be useful to check now.

Igor.

----- Original Message ----- 
From: "Dan Coby" <[email protected]>
To: "Gs-Code-Review" <[email protected]>
Sent: Wednesday, March 10, 2004 9:53 AM
Subject: [gs-code-review] Fix for 687349 A wrong comment forgx_device_color_s


> 
> Log message:
> 
> Fix for 687349 A wrong comment for gx_device_color_s.  This change
> modifies the comment on ccolor and the related variable ccolor_valid.
> 
> 
> Index: src/gsdcolor.h
> ===================================================================
> RCS file: /cvs/ghostscript/gs/src/gsdcolor.h,v
> retrieving revision 1.12
> diff -u -r1.12 gsdcolor.h
> --- a/src/gsdcolor.h    26 Aug 2003 12:37:13 -0000      1.12
> +++ b/src/gsdcolor.h    10 Mar 2004 06:50:39 -0000
> @@ -306,9 +306,21 @@
>         } /*(colored) */ pattern;
>      } colors;
>      gs_int_point phase;
> +    /*
> +     * This flag indicates if the paint values in ccolor are valid.  They
> +     * are valid for most cases.  However there are some special cases
> +     * in which a device color is initialized to specific values (usually
> +     * black or white) instead of being created from a color space and
> +     * color values.
> +     */
>      bool ccolor_valid;
> -    gs_client_color ccolor;    /* needed for remapping patterns, */
> -                               /* not set for non-pattern colors */
> +    /*
> +     * For non-pattern colors, ccolors contains the original paint values.
> +     * For pattern colors, ccolors contains information required for
> remapping.
> +     * the pattern.  See ccolor_valid.
> +     */
> +    gs_client_color ccolor;
> +
>      struct _mask {
>         struct mp_ {
>             short x, y;
> 
> _______________________________________________
> gs-code-review mailing list
> [email protected]
> http://www.ghostscript.com/mailman/listinfo/gs-code-review
>