RE: Bug 686956 Display device does not support separations

Dan,

No particular reason.  gp_file_name_sizeof (and anything in gp.h ) is 
not known in the client, hence I used a fixed size 64, which is 
larger than I expect a separation name to be.  I'll change gdevdsp.c 
to use a size of 64 bytes for the separation name, before doing the 
commit.    Thanks.

Russell

> Russell,
> 
> Looks good.
> 
> One question:  I note that you have name (which holds a separation name)
> defined in dwing.h as "char name[64]".  However in display_set_separations
> in gdevdsp.c you have "char name[gp_file_name_sizeof]".  Why use different
> sizes for two items which have the same basic purpose?
> 
> Dan
> 
> 
> -----Original Message-----
> From: [email protected]
> [mailto:[email protected]]On Behalf Of Russell Lang
> Sent: Friday, July 02, 2004 3:39 AM
> To: [email protected]
> Subject: [gs-code-review] Bug 686956 Display device does not
> supportseparations
> 
> 
> Ray, Dan,
> 
> This patch is the code that I have previously sent to Dan.
> 
> Log Message:
> Add support for separations to display device.
> This requires a change to the display callback structure.
> Support is maintained for clients using version 1 of the structure.
> Fixes bug 686956 Display device does not support separations.
> 
> DETAILS:
> Add support for a new color format, DISPLAY_COLORS_SEPARATION,
> which supports CMYK and spot colors.  A new callback
> display_separation() is used to tell the client about
> the names and CMYK equivalents of each separation.
> The callback structure version number is incremented to 2
> to show that has changed.  The display devices checks
> whether it is passed the older v1 structure or the newer
> v2 structure, and only calls the new separation callback
> if it was given a v2 structure.
> Only 8-bit/pixel, up to 8 components and 64-bit depth are supported.
> In the Windows and gtk+ clients, a subset of these 8 separations
> can be selected for display.
> The new code is based on the tiffsep device.
> 
> 
> Russell Lang                   [email protected]
> Ghostgum Software Pty Ltd      http://www.ghostgum.com.au/
> 
> 
> 
>