gp_check_interrupts() crashes (was: [gs-cvs] gs/src )

Stefan,

> Streams use a null memory pointer to indicate stack allocated.

In the case I've patched,
the memory pointer was not initialized.
So either your statement isn't generally correct,
or we had an indeterministic bug before your patch.
Maybe the clist stream is a special case, 
in which your statement isn't applicable.

Igor.


----- Original Message ----- 
From: "Igor V. Melichev" <[email protected]>
To: "Stefan Kemper" <[email protected]>
Cc: "'gs-code-review'" <[email protected]>
Sent: Wednesday, August 25, 2004 9:22 PM
Subject: Re: [gs-cvs] gs/src


> Stefan,
> 
> All related information is stored into
> http://bugs.ghostscript.com/show_bug.cgi?id=687624
> (the CVS log message reflects that).
> 
> > Please send me a email containing the test file and the command line.
> 
> The URL above includes them.
> 
> > gp_check_interrupts() crashes isn't something you should be fixing.  
> 
> The pdfwrite test didn't go with it.
> I patched to make it working.
> I'm sorry.
> I'll appreciate if you improve it so far.
> 
> Igor.
> 
> 
> ----- Original Message ----- 
> From: "Stefan Kemper" <[email protected]>
> To: "Igor Melichev" <[email protected]>
> Cc: <[email protected]>
> Sent: Tuesday, August 24, 2004 8:35 PM
> Subject: Re: [gs-cvs] gs/src
> 
> 
> > This is dangerous.
> > 
> > Streams use a null memory pointer to indicate stack allocated.
> > 
> > gp_check_interrupts() crashes isn't something you should be fixing.  
> > 
> > Please send me a email containing the test file and the command line.
> > 
> > ./Stefan
> > 
> > 
> > On Tue, 2004-08-24 at 09:36, Igor Melichev wrote:
> > > Update of /cvs/ghostscript/gs/src
> > > In directory casper2:/tmp/cvs-serv24368/gs/src
> > > 
> > > Modified Files:
> > > gxclread.c 
> > > Log Message:
> > > Fix : gs_lib_ctx was not accessible while clist_playback_band.
> > > 
> > > DETAILS :
> > > 
> > > Bug 687624 "A crash in gp_check_interrupts".
> > > 
> > > 
> > > EXPECTED DIFFERENCES :
> > > 
> > > Fixes crash with re-distilled files :
> > > Svd.pdf
> > > test.pdf
> > > 
> > > 
> > > Index: gxclread.c
> > > ===================================================================
> > > RCS file: /cvs/ghostscript/gs/src/gxclread.c,v
> > > retrieving revision 1.11
> > > retrieving revision 1.12
> > > diff -u -d -r1.11 -r1.12
> > > --- gxclread.c 5 Aug 2004 17:02:36 -0000 1.11
> > > +++ gxclread.c 24 Aug 2004 15:36:08 -0000 1.12
> > > @@ -510,6 +510,8 @@
> > >  s_std_init(&s, sbuf, cbuf_size, &no_procs, s_mode_read);
> > >  s.foreign = 1;
> > >  s.state = (stream_state *)&rs;
> > > + s.memory = mem; /* The stream doesn't need a memory,
> > > +                    but we'll need to access s.memory->gs_lib_ctx. */
> > >  code = clist_playback_band(action, cdev, &s, target, x0, y0, mem);
> > >      }
> > >  
> > > 
> > > _______________________________________________
> > > gs-cvs mailing list
> > > [email protected]
> > > http://www.ghostscript.com/mailman/listinfo/gs-cvs
> > > 
> >