Re: Pending code review |

Russell,

Sorry for the delay.

Russell Lang wrote:
> Could you please do code review for the following?
> 
> Win64 compile
> http://ghostscript.com/pipermail/gs-code-review/2005-February/004732.html

Approved for commit.

> Default page size  (currently missing doc patches, but please check 
> code)
> http://ghostscript.com/pipermail/gs-code-review/2005-February/004733.html

> Do we want DEFAULTPAPERSIZE to be documented, or internal to 
> gs_init.ps?

Please add this to doc/Use.htm with a statement to the effect that:

"This value will be used to replace the device default papersize ONLY
if the default papersize for the device is 'letter' or 'a4' serving
to insulate users of A4 or 8.5x11 from particular device defaults
(the collection of contributed drivers in Ghostscript vary as to
the default size)."

along with a suitable description of the usage. Also, please fix
the old section "Changing the installed default paper size" with
a comment that this supercedes the previous method of uncommenting
the line:  % (a4)

> Should the "/DEFAULTPAGESIZE (a4) def" be put in a separate file
> to make it easy for distributions to change?

I don't think so. It isn't hard to do this way (certainly similar to
the previous 'uncomment' in gs_init.

> 64-bit DisplayHandle
> http://ghostscript.com/pipermail/gs-code-review/2005-March/004743.html

Approved for commit.

> Raster alignment in display device can not be less than pointer size
> http://ghostscript.com/pipermail/gs-code-review/2005-March/004745.html

Approved for commit.

> Bug #687958 gswin32: Assertion fails due to a bug in dwtext.c
> http://ghostscript.com/pipermail/gs-code-review/2005-March/004744.html

Approved for commit (actually this one was already committed).

Regards,
Ray