Re: Fix for 687985, Incorrect code in GS_8_1X gsijs_finish_copydevice, |

Ray Johnston <[email protected]> Thu, 17 Mar 2005 14:42:51 -0800
Newsgroups gmane.comp.printing.ghostscript.patches
Message-ID <[email protected]>
Alex,

Thanks for fixing this. Please commit it. I will remind you to at
least compile in your gs 8.1x branch before committing. I've also
occasionally tripped over things when backporting fixes to 8.1x,
but usually I remember to compile and smoke test so I get it before
the commit.

Regards,
Ray
__________________________________________________________________________

Alex Cherepanov wrote:

> Remove memory argument from the call to gs_malloc() , which is not
> supported in GS_8_1X branch. This bug was introduced with the fix to the
> bug 687013 .
> Fix bug 687985
> 
> 
> ------------------------------------------------------------------------
> 
> Index: gs/src/gdevijs.c
> ===================================================================
> RCS file: /cvs/ghostscript/gs/src/gdevijs.c,v
> retrieving revision 1.6.2.3
> diff -b -u -r1.6.2.3 gdevijs.c
> --- gs/src/gdevijs.c	10 Mar 2005 15:02:07 -0000	1.6.2.3
> +++ gs/src/gdevijs.c	17 Mar 2005 12:50:33 -0000
> @@ -629,8 +629,7 @@
>          return code;
>      
>      if (!ijsdev->ColorSpace) {
> -	ijsdev->ColorSpace = gs_malloc(ijsdev->memory, sizeof(rgb), 1, 
> -		"gsijs_finish_copydevice");
> +	ijsdev->ColorSpace = gs_malloc(sizeof(rgb), 1, "gsijs_finish_copydevice");
>          if (!ijsdev->ColorSpace)
>   	    return gs_note_error(gs_error_VMerror);
>          ijsdev->ColorSpace_size = sizeof(rgb);
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> gs-code-review mailing list
> [email protected]
> http://www.ghostscript.com/mailman/listinfo/gs-code-review