Fix evaluation order in bbox deice

Alex Cherepanov <[email protected]> Sun, 09 Aug 2009 23:44:44 -0400
Newsgroups gmane.comp.printing.ghostscript.patches
Message-ID <[email protected]>
This is a multi-part message in MIME format.
--------------030703090502000005060104
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Fix expression evaluation order in bbox device to avoid
access to uninitialized color and Purify warning.

Regression testing shows no differences.


--------------030703090502000005060104
Content-Type: text/plain;
 name="aaa.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="aaa.diff"

Index: gs/base/gdevbbox.c
===================================================================
--- gs/base/gdevbbox.c	(revision 9930)
+++ gs/base/gdevbbox.c	(working copy)
@@ -234,7 +234,7 @@
 }
 
 #define GX_DC_IS_TRANSPARENT(pdevc, bdev)\
-  (gx_dc_pure_color(pdevc) == (bdev)->transparent && gx_dc_is_pure(pdevc))
+  (gx_dc_is_pure(pdevc) && gx_dc_pure_color(pdevc) == (bdev)->transparent)
 
 static int
 bbox_close_device(gx_device * dev)

--------------030703090502000005060104
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
gs-code-review mailing list
[email protected]
http://www.ghostscript.com/mailman/listinfo/gs-code-review

--------------030703090502000005060104--