New Ghostscript/GhostPDL compiler warnings - 2017-11-02-21:15:03 - 1ab17bc53362ea34b61050429c51c575539bf2b9

Previous Revision: b3c0fafa490932cc43009c53c7f8a17598fe78d7
 Current Revision: 1ab17bc53362ea34b61050429c51c575539bf2b9

commit 1ab17bc53362ea34b61050429c51c575539bf2b9
Author:     Robin Watts <[email protected]>
AuthorDate: Tue Oct 31 19:37:10 2017 +0000
CommitDate: Wed Nov 1 14:58:22 2017 +0000

    Avoid clearing cm_comps arrays in cmap functions.
    
    This goes against commit 99c48263b9 by Ray (dating from Nov 1 2009)
    to fix Bug 690713 and solve some indeterminisms.
    
    My belief is that this SHOULD be fixed in the devices, not in the
    callers. Accordingly I have backed that out, and changed the
    cmyk_cs_to_psdcmyk_cm function (the only one I can find that does
    not set everything to be 0).
    
    The cluster now shows this running with no diffs.

base/gxcmap.c
devices/gdevpsd.c



Ghostscript:

new scan-build warnings:

./base/gxcmap.c:1318:29: warning: Assigned value is garbage or undefined
                cm_comps[i] = gx_map_color_frac(pgs,
                            ^ ~~~~~~~~~~~~~~~~~~~~~~

./base/gxcmap.c:1318:31: warning: Function call argument is an uninitialized value
                cm_comps[i] = gx_map_color_frac(pgs,
                              ^~~~~~~~~~~~~~~~~~~~~~

./base/gxcmap.c:1323:39: warning: The right operand of '-' is a garbage value
                        (frac)(frac_1 - cm_comps[i]), effective_transfer[i]);
                                      ^ ~~~~~~~~~~~

./base/gxcmap.c:1378:21: warning: The left operand of '<<' is a garbage value
            cv[i] = frac2cv(cm_comps[i]);
                    ^       ~~~~~~~~~~~

./base/gxcmap.c:1381:25: warning: Assigned value is garbage or undefined
            cm_comps[i] = gx_map_color_frac(pgs,
                        ^ ~~~~~~~~~~~~~~~~~~~~~~

./base/gxcmap.c:1381:27: warning: Function call argument is an uninitialized value
            cm_comps[i] = gx_map_color_frac(pgs,
                          ^~~~~~~~~~~~~~~~~~~~~~

./base/gxcmap.c:1388:39: warning: The right operand of '-' is a garbage value
                        (frac)(frac_1 - cm_comps[i]), effective_transfer[i]);
                                      ^ ~~~~~~~~~~~


http://miles.ghostscript.com:8080/artifex/1ab17bc53362ea34b61050429c51c575539bf2b9/gs/index.html

http://miles.ghostscript.com:8080/artifex/1ab17bc53362ea34b61050429c51c575539bf2b9/gs-scan-build.txt




GhostPCL:

new scan-build warnings:

./base/gxcmap.c:1318:29: warning: Assigned value is garbage or undefined
                cm_comps[i] = gx_map_color_frac(pgs,
                            ^ ~~~~~~~~~~~~~~~~~~~~~~

./base/gxcmap.c:1318:31: warning: Function call argument is an uninitialized value
                cm_comps[i] = gx_map_color_frac(pgs,
                              ^~~~~~~~~~~~~~~~~~~~~~

./base/gxcmap.c:1323:39: warning: The right operand of '-' is a garbage value
                        (frac)(frac_1 - cm_comps[i]), effective_transfer[i]);
                                      ^ ~~~~~~~~~~~

./base/gxcmap.c:1378:21: warning: The left operand of '<<' is a garbage value
            cv[i] = frac2cv(cm_comps[i]);
                    ^       ~~~~~~~~~~~

./base/gxcmap.c:1381:25: warning: Assigned value is garbage or undefined
            cm_comps[i] = gx_map_color_frac(pgs,
                        ^ ~~~~~~~~~~~~~~~~~~~~~~

./base/gxcmap.c:1381:27: warning: Function call argument is an uninitialized value
            cm_comps[i] = gx_map_color_frac(pgs,
                          ^~~~~~~~~~~~~~~~~~~~~~

./base/gxcmap.c:1388:39: warning: The right operand of '-' is a garbage value
                        (frac)(frac_1 - cm_comps[i]), effective_transfer[i]);
                                      ^ ~~~~~~~~~~~


http://miles.ghostscript.com:8080/artifex/1ab17bc53362ea34b61050429c51c575539bf2b9/pcl/index.html

http://miles.ghostscript.com:8080/artifex/1ab17bc53362ea34b61050429c51c575539bf2b9/pcl-scan-build.txt