New Ghostscript/GhostPDL compiler warnings - 2017-11-03-05:45:02 - 8200f59f1b5aab852e23322587dda7c182fc195b

Previous Revision: 1626f36c9b6ae68abad7818be7cfb2a95f4ecffe
 Current Revision: 8200f59f1b5aab852e23322587dda7c182fc195b

commit 8200f59f1b5aab852e23322587dda7c182fc195b
Author:     Ray Johnston <[email protected]>
AuthorDate: Fri Oct 27 08:03:36 2017 -0700
CommitDate: Thu Nov 2 19:34:24 2017 -0700

    Fix Bug696372: Transparency with DeviceN not coping with bad PDF's
    
    When a PDF with transparency stops interpretation due to an error, the
    grestore may have popped the pgs so that the pdf14 compositor is no
    longer the currentdevice. The logic in pad14_spot_get_color_comp_index
    assumed that the device was a pdf14_device and got a bogus pointer to
    devn_params. Instead, use the device's ret_devn_params function to get
    the actual pointer.
    
    Also, the poppdf14devicefilter would execute without the pdf14 device
    as the currentdevice. Save the annots_gstate explicitly in pdf_main
    showpagecontents so it can be set back before doing annots and the
    poppdf14devicefilter.
    
    This also required gs_setgstate to always do gs_do_set_overprint since
    the setgstate may have skipped over states with the overprint compositor.
    This caused "drawn_comps" to not be set correctly for the pdf14
    compose_group.
    
    Fixups for 696372 fix commit (also ne->be last line of commit msg)

Resource/Init/pdf_main.ps
base/gdevp14.c
base/gsstate.c



Ghostscript:

new gcc warnings (gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609): 

./base/gdevp14.c:8254:14: warning: comparison of distinct pointer types lacks a cast

http://miles.ghostscript.com:8080/artifex/8200f59f1b5aab852e23322587dda7c182fc195b/gs-gcc-warnings.txt



new clang warnings (clang version 3.8.0-2ubuntu4 (tags/RELEASE_380/final)): 

./base/gdevp14.c:8254:14: warning: comparison of distinct pointer types ('gx_device *' (aka 'struct gx_device_s *') and 'pdf14_device *' (aka 'struct pdf14_device_s *')) [-Wcompare-distinct-pointer-types]
    if (tdev == pdev)
        ~~~~ ^  ~~~~


http://miles.ghostscript.com:8080/artifex/8200f59f1b5aab852e23322587dda7c182fc195b/gs-clang-warnings.txt



new scan-build warnings:

./base/gdevp14.c:8254:14: warning: comparison of distinct pointer types lacks a cast
     if (tdev == pdev)
              ^


http://miles.ghostscript.com:8080/artifex/8200f59f1b5aab852e23322587dda7c182fc195b/gs/index.html

http://miles.ghostscript.com:8080/artifex/8200f59f1b5aab852e23322587dda7c182fc195b/gs-scan-build.txt




GhostPCL:

new gcc warnings (gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609): 

./base/gdevp14.c:8254:14: warning: comparison of distinct pointer types lacks a cast

http://miles.ghostscript.com:8080/artifex/8200f59f1b5aab852e23322587dda7c182fc195b/pcl-gcc-warnings.txt



new scan-build warnings:

./base/gdevp14.c:8254:14: warning: comparison of distinct pointer types lacks a cast
     if (tdev == pdev)
              ^


http://miles.ghostscript.com:8080/artifex/8200f59f1b5aab852e23322587dda7c182fc195b/pcl/index.html

http://miles.ghostscript.com:8080/artifex/8200f59f1b5aab852e23322587dda7c182fc195b/pcl-scan-build.txt