New Ghostscript/GhostPDL compiler warnings - 2017-12-18-12:00:04 - f34cae2ebb2c85c13787fd828eb6194e32cb19d2

Previous Revision: 9fb23615725e8a2d6a722814a348094a48a41c36
 Current Revision: f34cae2ebb2c85c13787fd828eb6194e32cb19d2

commit f34cae2ebb2c85c13787fd828eb6194e32cb19d2
Author:     Robin Watts <[email protected]>
AuthorDate: Wed Dec 13 15:37:53 2017 +0000
CommitDate: Mon Dec 18 18:43:27 2017 +0000

    Optimise image_render_interpolate_icc.
    
    Split out the core of the routine into a function call. The
    guts of the original routine go into irii_inner_template,
    which can be static instantiated as required.
    
    I had hoped that merely instantiating this 3 times would be
    enough to optimise the routines, but in the end I had to
    manually cut the core down for the 2 cases that the AirPrint
    test file hits.

base/gxiscale.c
windows/GhostPDL.sln



Ghostscript:

new scan-build warnings:

./base/gxiscale.c:1637:13: warning: The left operand of '==' is a garbage value
        if (color_is_pure(&devc)) {
            ^~~~~~~~~~~~~~~~~~~~

./base/gxiscale.c:1726:25: warning: Value stored to 'expand' is never read
                        expand = interpolate_scaled_expanded_width(1, pss);
                        ^        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

./base/gxiscale.c:1728:25: warning: Value stored to 'expand' is never read
                        expand = 1;
                        ^        ~

./base/gxiscale.c:1864:13: warning: The left operand of '==' is a garbage value
        if (color_is_pure(&devc)) {
            ^~~~~~~~~~~~~~~~~~~~

./base/gxiscale.c:1937:13: warning: The left operand of '==' is a garbage value
        if (color_is_pure(&devc)) {
            ^~~~~~~~~~~~~~~~~~~~


http://miles.ghostscript.com:8080/artifex/f34cae2ebb2c85c13787fd828eb6194e32cb19d2/gs/index.html

http://miles.ghostscript.com:8080/artifex/f34cae2ebb2c85c13787fd828eb6194e32cb19d2/gs-scan-build.txt




GhostPCL:

new scan-build warnings:

./base/gxiscale.c:1637:13: warning: The left operand of '==' is a garbage value
        if (color_is_pure(&devc)) {
            ^~~~~~~~~~~~~~~~~~~~

./base/gxiscale.c:1726:25: warning: Value stored to 'expand' is never read
                        expand = interpolate_scaled_expanded_width(1, pss);
                        ^        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

./base/gxiscale.c:1728:25: warning: Value stored to 'expand' is never read
                        expand = 1;
                        ^        ~

./base/gxiscale.c:1864:13: warning: The left operand of '==' is a garbage value
        if (color_is_pure(&devc)) {
            ^~~~~~~~~~~~~~~~~~~~

./base/gxiscale.c:1937:13: warning: The left operand of '==' is a garbage value
        if (color_is_pure(&devc)) {
            ^~~~~~~~~~~~~~~~~~~~


http://miles.ghostscript.com:8080/artifex/f34cae2ebb2c85c13787fd828eb6194e32cb19d2/pcl/index.html

http://miles.ghostscript.com:8080/artifex/f34cae2ebb2c85c13787fd828eb6194e32cb19d2/pcl-scan-build.txt