New Ghostscript/GhostPDL compiler warnings - 2018-04-05-12:45:07 - 4372854939842240c7edb58dd0fa285a0c2f15b1

[email protected] Thu, 5 Apr 2018 14:02:13 -0700 (PDT)
Newsgroups gmane.comp.printing.ghostscript.regression
Message-ID <20180405210213.AE5EA204050F@i7>
Previous Revision: 5886c28f2a7376ad3818dadeb9cc3c6989f7702a
 Current Revision: 4372854939842240c7edb58dd0fa285a0c2f15b1

commit 4372854939842240c7edb58dd0fa285a0c2f15b1
Author:     Robin Watts <[email protected]>
AuthorDate: Thu Apr 5 16:28:01 2018 +0100
CommitDate: Thu Apr 5 18:14:51 2018 +0100

    Another attempt at fixing the 'skip' logic for halftoned images.
    
    When rendering images, if the dda is not shared between the
    halftoner and gs, gs cannot just skip lines that it knows should
    be clipped, lest the halftoner get confused about it.
    
    The previous attempt to solve this used a separate 'skip_render'
    routine, but the decision as to whether to call this or not was
    itself dependent on the values of the dda. When scaling down
    scanlines can be completely skipped. In the cases where the dda
    in gs doesn't match the one in the halftoner exactly we could
    get dropouts.
    
    So, a new attempt. Here we introduce a new function call that
    checks with the halftoner whether the next scanline will be
    required or not. If it is, gs unpacks the data and passes it in.
    If not, the data can just be skipped.

base/gxidata.c
base/gximage.h
base/gxipixel.c



Ghostscript:

new cppcheck warnings (Cppcheck 1.72): 

base/gxidata.c:91: error: Shifting a negative value is undefined behaviour
base/gxidata.c:94: error: Shifting a negative value is undefined behaviour

http://miles.ghostscript.com:8080/artifex/4372854939842240c7edb58dd0fa285a0c2f15b1/gs-cppcheck.txt