all devices regression report - 2018-04-12-05:41:58 - dfbf92a35d2be0aaa35bdb301c0647deec55b054
[email protected] Thu, 12 Apr 2018 05:41:58 -0700 (PDT)
| Newsgroups | gmane.comp.printing.ghostscript.regression |
|---|---|
| Message-ID | <20180412124158.862E3204050F@i7> |
Differences in all devices errors using gs/examples files Previous Revision: b9e0722267e8770c01914da28f924cffcae1c0b8 Current Revision: dfbf92a35d2be0aaa35bdb301c0647deec55b054 commit dfbf92a35d2be0aaa35bdb301c0647deec55b054 Author: Robin Watts <[email protected]> AuthorDate: Wed Apr 11 19:37:07 2018 +0100 CommitDate: Thu Apr 12 11:52:36 2018 +0100 Attempt to fix vertical shifts seen in halftoning. Differences are evident between old (slow, non SSE based) and new (fast, C/SSE based) halftoning. This is not because of the SSE, but rather because of different calculations in the C that prepares the screen for the fast SSE based thresholding, specifically, I believe, to the calculation of the y offset into the texture tile. This commit changes the texture tile y offset calculation in the 'fast' code to involve screen_phase.y, in the hopes that this will better match the 'old' version. With this fix in, we see just a few PS/PDF diffs, but lots of PCL diffs (as I guess you'd expect, as PCL makes much more use of this kind of stuff). I've checked a random selection of them, and in all cases the new page mode renderings with the "fast" code match the page mode renderings given by the "old" code. There are instances where the clist rendering no longer matches the page mode rendering, but in the tests I've done the clist old code does match the clist fast code. So we are consistent at least. I suspect that there is something up with the way the y_phase is transmitted across the clist, and have opened bug 699209 to track that. base/gxht_thresh.c new errors: errors that went away: errors that are not whitelisted: === ghostpdl/examples/text_graph_image_cmyk_rgb.pdf === pxlcolor === === ghostpdl/examples/text_graph_image_cmyk_rgb.pdf === pxlmono ===