New Ghostscript/GhostPDL compiler warnings - 2018-08-10-02:15:05 - 9cb7fbd8ca2f2dee6652d832c76da16b85a5f730

Previous Revision: 12a188d18097e2161f3d653b677e55f558d57faf
 Current Revision: 9cb7fbd8ca2f2dee6652d832c76da16b85a5f730

commit 9cb7fbd8ca2f2dee6652d832c76da16b85a5f730
Author:     Ken Sharp <[email protected]>
AuthorDate: Thu Jul 26 17:39:40 2018 +0100
CommitDate: Thu Aug 9 16:05:56 2018 +0100

    Device Subclassing - fix memory leaks with child device
    
    We should not patch out the finalize routine (now that we have a custom
    one), that prevents the child device finalize being run, leading to
    memory leaks with ICC profiles.
    
    Also, now we have a finalize routine, we need to free the child device
    if there is one present. The child device's own finalize routine will
    clean everything up.

base/gdevdflt.c
base/gdevsclass.c



Ghostscript:

new gcc warnings (gcc (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609): 

./base/gdevdflt.c:1517:38: warning: unused variable 'b_std' [-Wunused-variable]

http://miles.ghostscript.com:8080/artifex/9cb7fbd8ca2f2dee6652d832c76da16b85a5f730/gs-gcc-warnings.txt



new clang warnings (clang version 3.8.0-2ubuntu4 (tags/RELEASE_380/final)): 

./base/gdevdflt.c:1517:38: warning: unused variable 'b_std' [-Wunused-variable]
            gs_memory_struct_type_t *b_std = (gs_memory_struct_type_t *)child->stype;
                                     ^


http://miles.ghostscript.com:8080/artifex/9cb7fbd8ca2f2dee6652d832c76da16b85a5f730/gs-clang-warnings.txt



new scan-build warnings:

./base/gdevdflt.c:1517:38: warning: Value stored to 'b_std' during its initialization is never read
            gs_memory_struct_type_t *b_std = (gs_memory_struct_type_t *)child->stype;
                                     ^~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

./base/gdevdflt.c:1517:38: warning: unused variable 'b_std' [-Wunused-variable]
             gs_memory_struct_type_t *b_std = (gs_memory_struct_type_t *)child->stype;
                                      ^


http://miles.ghostscript.com:8080/artifex/9cb7fbd8ca2f2dee6652d832c76da16b85a5f730/gs/index.html

http://miles.ghostscript.com:8080/artifex/9cb7fbd8ca2f2dee6652d832c76da16b85a5f730/gs-scan-build.txt




GhostPCL:

new gcc warnings (gcc (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609): 

./base/gdevdflt.c:1517:38: warning: unused variable 'b_std' [-Wunused-variable]

http://miles.ghostscript.com:8080/artifex/9cb7fbd8ca2f2dee6652d832c76da16b85a5f730/pcl-gcc-warnings.txt



new scan-build warnings:

./base/gdevdflt.c:1517:38: warning: Value stored to 'b_std' during its initialization is never read
            gs_memory_struct_type_t *b_std = (gs_memory_struct_type_t *)child->stype;
                                     ^~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

./base/gdevdflt.c:1517:38: warning: unused variable 'b_std' [-Wunused-variable]
             gs_memory_struct_type_t *b_std = (gs_memory_struct_type_t *)child->stype;
                                      ^


http://miles.ghostscript.com:8080/artifex/9cb7fbd8ca2f2dee6652d832c76da16b85a5f730/pcl/index.html

http://miles.ghostscript.com:8080/artifex/9cb7fbd8ca2f2dee6652d832c76da16b85a5f730/pcl-scan-build.txt