New Ghostscript/GhostPDL compiler warnings - 2018-08-21-07:30:19 - 50ef2aa8c28f0eb097b8dab3effbe6b1c3948879

Previous Revision: 678261f0d973badfc4609e9e7b27a1d039609ebb
 Current Revision: 50ef2aa8c28f0eb097b8dab3effbe6b1c3948879

commit 50ef2aa8c28f0eb097b8dab3effbe6b1c3948879
Author:     Chris Liddell <[email protected]>
AuthorDate: Mon Aug 20 15:18:27 2018 +0100
CommitDate: Tue Aug 21 13:39:32 2018 +0100

    Fix "ignored return code" Coverity errors.
    
    Several places in pl_main_process_options(), we were ignoring return codes -
    particularly, cases where a genuine error is possible.
    
    Rather than handle each error case automatically, drop out of the switch,
    and catch the error before jumping to the top of the while loop.
    
    For consistency, ignore the error triggered by -dBATCH

pcl/pl/plmain.c



GhostPCL:

new gcc warnings (gcc (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609): 

./pcl/pl/plmain.c:1089:24: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]

http://miles.ghostscript.com:8080/artifex/50ef2aa8c28f0eb097b8dab3effbe6b1c3948879/pcl-gcc-warnings.txt



new scan-build warnings:

./pcl/pl/plmain.c:1089:24: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]
                     if (code != e_ExitLanguage)
                        ^

./pcl/pl/plmain.c:834:17: warning: Value stored to 'code' is never read
                code = -1;
                ^      ~~


http://miles.ghostscript.com:8080/artifex/50ef2aa8c28f0eb097b8dab3effbe6b1c3948879/pcl/index.html

http://miles.ghostscript.com:8080/artifex/50ef2aa8c28f0eb097b8dab3effbe6b1c3948879/pcl-scan-build.txt