New Ghostscript/GhostPDL compiler warnings - 2018-10-18-14:45:06 - 3b8f34c00e6ed1f7b4847a55d48b8027c0b0b946

Previous Revision: 29113956bb0599209ca81698ab36736e373f054a
 Current Revision: 3b8f34c00e6ed1f7b4847a55d48b8027c0b0b946

commit 3b8f34c00e6ed1f7b4847a55d48b8027c0b0b946
Author:     Robin Watts <[email protected]>
AuthorDate: Thu Apr 19 12:45:14 2018 +0100
CommitDate: Thu Oct 18 15:41:15 2018 +0100

    Add "transform_pixel_region" device function.
    
    Use this for handling image type 4 rendering.
    
    The default version of this goes to rectangles. It also knows how to
    send portrait images of 8bps to copy_color.
    
    Next step is to write versions of this for the memory mapped devices
    to know how to go direct.
    
    Essentially we are copying the guts of the
    image_render_color_icc_{portrait,landscape,skew} into a default
    device method, and making the code that called those functions
    call the device method instead.

base/gdevdflt.c
base/gdevepo.c
base/gdevflp.c
base/gdevmplt.c
base/gdevnfwd.c
base/gdevoflt.c
base/gdevsclass.c
base/gdevsclass.h
base/gxclip.c
base/gxclipm.c
base/gxclist.c
base/gxcmap.c
base/gxcmap.h
base/gxdevcli.h
base/gxdevice.h
base/gxi12bit.c
base/gxicolor.c
base/gxidata.c
base/gximage.h
devices/vector/gdevpdfd.c
devices/vector/gdevpdfx.h
doc/Drivers.htm
windows/ghostscript.vcproj



Ghostscript:

new gcc warnings (gcc (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609): 

./base/gdevflp.c:1216:5: warning: 'flp_transform_pixel_region' defined but not used [-Wunused-function]

http://miles.ghostscript.com:8080/artifex/3b8f34c00e6ed1f7b4847a55d48b8027c0b0b946/gs-gcc-warnings.txt



new clang warnings (clang version 3.8.0-2ubuntu4 (tags/RELEASE_380/final)): 

./base/gdevflp.c:1216:5: warning: unused function 'flp_transform_pixel_region' [-Wunused-function]
int flp_transform_pixel_region(gx_device *dev, transform_pixel_region_reason reason, transform_pixel_region_data *data)
    ^


http://miles.ghostscript.com:8080/artifex/3b8f34c00e6ed1f7b4847a55d48b8027c0b0b946/gs-clang-warnings.txt



new scan-build warnings:

./base/gdevdflt.c:1993:13: warning: Value stored to 'to_rects' is never read
            to_rects = 1;
            ^          ~

./base/gdevflp.c:1216:5: warning: 'flp_transform_pixel_region' defined but not used [-Wunused-function]
 int flp_transform_pixel_region(gx_device *dev, transform_pixel_region_reason reason, transform_pixel_region_data *data)
     ^

./base/gxicolor.c:937:80: warning: Division by zero
        penum_orig->used.x = (data.u.process_data.buffer[0] - psrc_cm_initial) / spp_cm;
                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~


http://miles.ghostscript.com:8080/artifex/3b8f34c00e6ed1f7b4847a55d48b8027c0b0b946/gs/index.html

http://miles.ghostscript.com:8080/artifex/3b8f34c00e6ed1f7b4847a55d48b8027c0b0b946/gs-scan-build.txt



new cppcheck warnings (Cppcheck 1.72): 

base/gxclist.c:539: error: Shifting a negative value is undefined behaviour

http://miles.ghostscript.com:8080/artifex/3b8f34c00e6ed1f7b4847a55d48b8027c0b0b946/gs-cppcheck.txt




GhostPCL:

new gcc warnings (gcc (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609): 

./base/gdevflp.c:1216:5: warning: 'flp_transform_pixel_region' defined but not used [-Wunused-function]

http://miles.ghostscript.com:8080/artifex/3b8f34c00e6ed1f7b4847a55d48b8027c0b0b946/pcl-gcc-warnings.txt



new scan-build warnings:

./base/gdevdflt.c:1993:13: warning: Value stored to 'to_rects' is never read
            to_rects = 1;
            ^          ~

./base/gdevflp.c:1216:5: warning: 'flp_transform_pixel_region' defined but not used [-Wunused-function]
 int flp_transform_pixel_region(gx_device *dev, transform_pixel_region_reason reason, transform_pixel_region_data *data)
     ^

./base/gxicolor.c:937:80: warning: Division by zero
        penum_orig->used.x = (data.u.process_data.buffer[0] - psrc_cm_initial) / spp_cm;
                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~


http://miles.ghostscript.com:8080/artifex/3b8f34c00e6ed1f7b4847a55d48b8027c0b0b946/pcl/index.html

http://miles.ghostscript.com:8080/artifex/3b8f34c00e6ed1f7b4847a55d48b8027c0b0b946/pcl-scan-build.txt