New Ghostscript/GhostPDL compiler warnings - 2018-12-04-15:45:02 - fae21f1668d2b44b18b84cf0923a1d5f3008a696

Previous Revision: 2e68cc460dbe349f68b81082ff7344db48eb4820
 Current Revision: fae21f1668d2b44b18b84cf0923a1d5f3008a696

commit fae21f1668d2b44b18b84cf0923a1d5f3008a696
Author:     Ken Sharp <[email protected]>
AuthorDate: Tue Dec 4 21:31:31 2018 +0000
CommitDate: Tue Dec 4 21:31:31 2018 +0000

    subclassing devices - fix put_image method
    
    The subclassing devices need to change the 'memory device' parameter to
    be the child device, when its the same as the subclassing device.
    
    Otherwise we end up trying to access the child device's memory pointers
    in the subclassing device, which may not contain valid copies of
    those pointers.

base/gdevsclass.c



Ghostscript:

new gcc warnings (gcc (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609): 

./base/gdevsclass.c:799:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]

http://miles.ghostscript.com:8080/artifex/fae21f1668d2b44b18b84cf0923a1d5f3008a696/gs-gcc-warnings.txt



new clang warnings (clang version 3.8.0-2ubuntu4 (tags/RELEASE_380/final)): 

./base/gdevsclass.c:802:9: warning: add explicit braces to avoid dangling else [-Wdangling-else]
        else
        ^


http://miles.ghostscript.com:8080/artifex/fae21f1668d2b44b18b84cf0923a1d5f3008a696/gs-clang-warnings.txt



new scan-build warnings:

./base/gdevsclass.c:799:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]
     if (dev->child)
        ^


http://miles.ghostscript.com:8080/artifex/fae21f1668d2b44b18b84cf0923a1d5f3008a696/gs/index.html

http://miles.ghostscript.com:8080/artifex/fae21f1668d2b44b18b84cf0923a1d5f3008a696/gs-scan-build.txt




GhostPCL:

new gcc warnings (gcc (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609): 

./base/gdevsclass.c:799:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]

http://miles.ghostscript.com:8080/artifex/fae21f1668d2b44b18b84cf0923a1d5f3008a696/pcl-gcc-warnings.txt



new scan-build warnings:

./base/gdevsclass.c:799:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]
     if (dev->child)
        ^


http://miles.ghostscript.com:8080/artifex/fae21f1668d2b44b18b84cf0923a1d5f3008a696/pcl/index.html

http://miles.ghostscript.com:8080/artifex/fae21f1668d2b44b18b84cf0923a1d5f3008a696/pcl-scan-build.txt