New Ghostscript/GhostPDL compiler warnings - 2019-05-03-07:46:14 - c2d50885614481ebf542578e69ce4bcbbfea6532

Previous Revision: 22d88ad48409a130007976ae26536cc9d99c16d9
 Current Revision: c2d50885614481ebf542578e69ce4bcbbfea6532

commit c2d50885614481ebf542578e69ce4bcbbfea6532
Author:     Ken Sharp <[email protected]>
AuthorDate: Fri May 3 13:27:22 2019 +0100
CommitDate: Fri May 3 15:37:16 2019 +0100

    DeviceN - handle attributes Subtype and cleaning up
    
    Previously we were ignoring the /Subtype in the attributes dictionary
    of a DeviceN colour space (if attributes were present). We may need to
    be able to tell the difference (now that we handle /Process) because
    the values associated with the process components must be stored in
    their natural form (eg subtractive for CMYK, additive for RGB) when
    the Subtype is NChannel.
    
    The remainder of the commit tidies up naming; previously we had a
    structure called gs_devicen_attributes, which was used to store the
    Colorants entry form an attributes dictionary. Since we now handle
    other aspects of the attributes dictionary as well, this was misleading
    so the structure has been renamed throughout as gs_devicen_colorant
    (since each structure defines only one colorant, the plural name was
    also misleading). Apparently pdfwrite is the only client for this
    currently anyway.
    
    Finally, moved the 'devn_process_space' from the general graphics
    state colour space structure into the DeviceN params structure, as its
    only relevant to DeviceN (and indeed only a DeviceN with an attributes
    dictionary which contains a /Process entry)

base/gscdevn.c
base/gscdevn.h
base/gscspace.c
base/gscspace.h
base/gxcdevn.h
devices/vector/gdevpdfc.c
devices/vector/gdevpdfg.c
psi/zcolor.c



Ghostscript:

new gcc warnings (gcc (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0 20160609): 

./base/gscdevn.c:188:1: warning: no previous prototype for 'gs_attachcolorant' [-Wmissing-prototypes]
./psi/zcolor.c:3792:13: warning: implicit declaration of function 'gs_attachcolorant' [-Wimplicit-function-declaration]
./psi/zcolor.c:3937:49: warning: unused variable 's2' [-Wunused-variable]

http://miles.ghostscript.com:8080/artifex/c2d50885614481ebf542578e69ce4bcbbfea6532/gs-gcc-warnings.txt



new clang warnings (clang version 3.8.0-2ubuntu4 (tags/RELEASE_380/final)): 

./base/gscdevn.c:188:1: warning: no previous prototype for function 'gs_attachcolorant' [-Wmissing-prototypes]
gs_attachcolorant(gs_separation_name sep_name, gs_gstate * pgs)
^

./psi/zcolor.c:3792:13: warning: implicit declaration of function 'gs_attachcolorant' is invalid in C99 [-Wimplicit-function-declaration]
            gs_attachcolorant(sep_name, igs);
            ^

./psi/zcolor.c:3937:49: warning: unused variable 's2' [-Wunused-variable]
            ref *process, *cspace, *parr, name, s2, *subtype;
                                                ^


http://miles.ghostscript.com:8080/artifex/c2d50885614481ebf542578e69ce4bcbbfea6532/gs-clang-warnings.txt



new scan-build warnings:

./base/gscdevn.c:188:1: warning: no previous prototype for 'gs_attachcolorant' [-Wmissing-prototypes]
 gs_attachcolorant(gs_separation_name sep_name, gs_gstate * pgs)
 ^

./psi/zcolor.c:3792:13: warning: implicit declaration of function 'gs_attachcolorant' [-Wimplicit-function-declaration]
             gs_attachcolorant(sep_name, igs);
             ^

./psi/zcolor.c:3937:49: warning: unused variable 's2' [-Wunused-variable]
             ref *process, *cspace, *parr, name, s2, *subtype;
                                                 ^

./psi/zcolor.c:3945:13: warning: Value stored to 'code' is never read
            code = array_get(imemory, devicenspace, 4, &sref);
            ^      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


http://miles.ghostscript.com:8080/artifex/c2d50885614481ebf542578e69ce4bcbbfea6532/gs/index.html

http://miles.ghostscript.com:8080/artifex/c2d50885614481ebf542578e69ce4bcbbfea6532/gs-scan-build.txt




GhostPCL:

new gcc warnings (gcc (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0 20160609): 

./base/gscdevn.c:188:1: warning: no previous prototype for 'gs_attachcolorant' [-Wmissing-prototypes]

http://miles.ghostscript.com:8080/artifex/c2d50885614481ebf542578e69ce4bcbbfea6532/pcl-gcc-warnings.txt



new scan-build warnings:

./base/gscdevn.c:188:1: warning: no previous prototype for 'gs_attachcolorant' [-Wmissing-prototypes]
 gs_attachcolorant(gs_separation_name sep_name, gs_gstate * pgs)
 ^


http://miles.ghostscript.com:8080/artifex/c2d50885614481ebf542578e69ce4bcbbfea6532/pcl/index.html

http://miles.ghostscript.com:8080/artifex/c2d50885614481ebf542578e69ce4bcbbfea6532/pcl-scan-build.txt