[bug #68370] Missing build dependencies in Makefiles

Follow-up Comment #3, bug #68370 (group groff):

[comment #2 comment #2:]
>> However, we may have gotten careless by having "pdfmom" declare a dependency
>> on pic...except I don't see one in its Automake file, either.
> 
> It is in mom.am.

> ../contrib/mom/mom.am:  $(PDFMOMBIN) $(FFLAG) $(MFLAG) -M$(mom_srcdir) -K
> utf8 -p -e -t \


With more context, we have:


# pdfmom command used to generate .pdf
#
# Use '-K utf8', not '-k', in case 'configure' didn't find uchardet.
MOMPDFMOM = \
  GROFF_COMMAND=test-groff \
  GROFF_COMMAND_PREFIX= \
  GROFF_BIN_PATH="$(GROFF_BIN_PATH)" \
  $(PDFMOMBIN) $(FFLAG) $(MFLAG) -M$(mom_srcdir) -K utf8 -p -e -t \
  -wall -b -P-W


https://cgit.git.savannah.gnu.org/cgit/groff.git/tree/contrib/mom/mom.am?h=1.24.1#n23

...and I don't see where anything outside of _mom_(7)'s directory expands the
`MOMPDFMOM` Make macro.  Which is good, because nothing should.  The `MOM`
_prefix_ to the macro implies its specificity to building stuff in _mom_(7)'s
own directory or "module".


groff-1.24.1 !5648$ grep -r MOMPDFMOM
contrib/mom/ChangeLog:  * mom.am (MOMPDFMOM): Add environment variable
`GROFF_COMMAND`,
contrib/mom/ChangeLog:  * mom.am (MOMPDFMOM): Append `-P -W` to `pdfmom`
arguments.
contrib/mom/ChangeLog:  variable in `MOMPDFMOM` macro housing shell command.
Nothing
contrib/mom/ChangeLog:  * mom.am: Add `-b` and `-wall` options to `MOMPDFMOM`
macro so
contrib/mom/ChangeLog:  * mom.am (MOMPDFMOM): Pass `PDFMOMBIN` '-K utf8', not
'-k', in
contrib/mom/ChangeLog:  (MOMPDFMOM): Track rename of Make macro `TFLAG` to
`MFLAG`.
contrib/mom/mom.am:MOMPDFMOM = \
contrib/mom/mom.am:     && LC_ALL=C $(MOMPDFMOM) $< >$@
Makefile.in:MOMPDFMOM = \
Makefile.in:    && LC_ALL=C $(MOMPDFMOM) $< >$@


So I don't think the mystery is solved quite yet.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?68370>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQQk97aszIMMAvLLwm6qLAuaBUf3TgUCagyjXAAKCRCqLAuaBUf3
TnhdAP4/RjdfII158MPCRKuBAzziOnueKc6IblA6Ffl41D9M6wD/ZT6RVqQz81H2
VF9W8V7V2GhYqCsdilFPBgrloU+Hqg8=
=Jn2B
-----END PGP SIGNATURE-----