[bug #68511] [troff] `hcode` doesn't work on ordinary characters since commit 994fcce775, 2026-05-24

"G. Branden Robinson" <[email protected]> Sun, 12 Jul 2026 09:44:31 -0400 (EDT)
Newsgroups gmane.comp.printing.groff.bugs
Message-ID <[email protected]>
Update of bug #68511 (group groff):

                  Status:             In Progress => Fixed
             Open/Closed:                    Open => Closed

    _______________________________________________________

Follow-up Comment #18:


commit e64bec590af55c29579ae4990665badc266f63a1
Author: G. Branden Robinson <[email protected]>
Date:   Sat Jul 11 19:26:56 2026 -0500

    [troff]: Fix Savannah #68511.
    
    ...recovering from a botched refactor.
    
    * src/roff/troff/input.cpp (read_any_character): New function reads any
      groff character--ordinary, special, or indexed--from the input stream,
      skipping any spaces.  While a fairly simple task, it can be done
      incorrectly nevertheless.  Multiple request handlers can use this.
      Start...
    
      (set_hyphenation_codes): ...here.  Rearrange "do/while" loop to
      "while" loop.  Advance the input stream after reading the destination
      character in a pair.  Failing to do so was the defect.  Simplify an
      error diagnostic message.  Simplify a conditional code path.
    
    Fixes <https://savannah.gnu.org/bugs/?68511>.  Problem introduced by me
    in commit 994fcce775, 24 May.  Thanks to Dave Kemper for the report.




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?68511>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
signature.asc (application/pgp-signature, 228 B)
-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQQk97aszIMMAvLLwm6qLAuaBUf3TgUCalOaPwAKCRCqLAuaBUf3
TkObAPwNBY4X6lq9xuaW91qN+GRkHXiP8bMgSt808qfQ/t5fswD+IfuazSQ4EP+f
Pdl5fM22ta5HGgwEHVGuo93lVavo0Ak=
=0iPR
-----END PGP SIGNATURE-----