[bug #68524] [troff] `hpf` and `hpfa` requests cause next input line to be ignored since commit 85c8daa27d, 2026-04-01

"G. Branden Robinson" <[email protected]> Fri, 17 Jul 2026 19:37:36 -0400 (EDT)
Newsgroups gmane.comp.printing.groff.bugs
Message-ID <[email protected]>
Update of bug #68524 (group groff):

                  Status:             In Progress => Fixed
             Open/Closed:                    Open => Closed

    _______________________________________________________

Follow-up Comment #5:


commit eeae97c6b40d08c43bf0a04967f4c64f89136e9f
Author: G. Branden Robinson <[email protected]>
Date:   Fri Jul 17 11:03:09 2026 -0500

    [groff]: Unit-test `hpf` and `hpfa` requests.
    
    * src/roff/groff/tests/hpf-request-works.sh:
    * src/roff/groff/tests/hpfa-request-works.sh: Do it.
    
    * src/roff/groff/groff.am (groff_TESTS): Run tests.
    
    Tests fail at this commit.

commit 8e458a0ab15bd3b7a20e69b2f7130769be6f983a
Author: G. Branden Robinson <[email protected]>
Date:   Tue Jul 14 02:56:12 2026 -0500

    [troff]: Fix Savannah #68524.
    
    * src/roff/troff/env.cpp (load_hyphenation_patterns_from_file_request)
      (append_hyphenation_patterns_from_file_request): Before returning,
      call `tok.next()` instead of `skip_line()`.  Annotate why: doing so
      prevents the formatter from ignoring the input line after the request.
    
    Fixes <https://savannah.gnu.org/bugs/?68524>.  Problem introduced by me
    in commit 85c8daa27d, 1 April.  Thanks to Dave Kemper for the report.




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?68524>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
signature.asc (application/pgp-signature, 228 B)
-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQQk97aszIMMAvLLwm6qLAuaBUf3TgUCalq8wAAKCRCqLAuaBUf3
TlftAQC+bOFgS+YeZsJwQhjF7zlPs75Q9pRGe8A7d5oIF3Cl4gD8Cm/eDHn0JAc7
+iEW7g7F1mMhiQE7/c1fXZiaEk3RVwU=
=1pi6
-----END PGP SIGNATURE-----