Re: "troff -a" is now communicating less information

"G. Branden Robinson" <[email protected]>
Newsgroups gmane.comp.printing.groff.general
Message-ID <20251217202014.szgikpgeol2ahzhz@illithid>
At 2025-12-16T19:31:31-0600, G. Branden Robinson wrote:
> I found the [commit] responsible for the [change].
> 
> I was able to revert it cleanly (i.e., no merge conflicts).

...but I won't be pushing that reversion without further discussion.

> You might be interested in what it was.
> 
> $ git show 3d249f79fd662e0e033ee1dc564f242b1a753e3c|cat
> commit 3d249f79fd662e0e033ee1dc564f242b1a753e3c
> Author: G. Branden Robinson <[email protected]>
> Date:   Mon Mar 17 01:19:54 2025 -0500
> 
>     [troff]: Fix Savannah #55799 (`-a` opt + `char`).
> 
>     * src/roff/troff/node.cpp (composite_node::ascii_print): When rendering
>       a composite node for approximate output, traverse into it and write
>       its nodes' representations in forward order.
> 
>     Fixes <https://savannah.gnu.org/bugs/?55799>.  Thanks to Dave Kemper for
>     the report.  Problem appears to date back to groff's birth.

Reverting this commit causes 3 automated test failures:

FAIL: src/roff/groff/tests/asciify-composite-nodes-correctly.sh
FAIL: src/roff/groff/tests/asciify-request-works.sh
FAIL: src/roff/groff/tests/composite-nodes-produce-approximate-output.sh

Regards,
Branden
signature.asc (application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEh3PWHWjjDgcrENwa0Z6cfXEmbc4FAmlDEHYACgkQ0Z6cfXEm
bc5YPg//QqUnTGHXUXrhXgh1D5YzdpyYgmin8UrNf20zaf2HgHnfNZDEEREBPTLl
WhTM9EKQSadPXfcuBhJFs24muP7uIap0OJ5ZK8tBGwFYUnJJvrckmmus0XdlCE2O
xLoIV2+ErS+lDa07evu/3hW4YRxgR1jPiXWBqZyvyXVI32iBiGdE7TwlySV6khqN
7j1CIK0rKMWJHYYCAJ+MDilmk0soC4plMvHDxdcZEkSgLPcWBvywYRBUTZ+7cKi2
aSagnmXBQzfoTc2GIW1+CLnhfXrQsuS0ARYIqnoZ8kEjlApCuF/jzEZenRbqvBAS
XfiZCyFZFpxckyhqmPjbm94OhUlvLTWl5iBs5coMwIJNVAPBEn2l7FtatR8JwwYR
o5lecvRnkX3OOSC5A+U+nwJHfFqLNOLFFaBl07bB0/SuFO81ao3mbCyciSe/YxLN
/iFvSUq030uFjPaKO4IDcHtd5x4b/SSILh1OQ5uO0ru68rBxv8G3rh6RTV00fvUN
/VzWT96mTPZT4CBGWPVxx80R3H7YMyadZQw6xPHV2/Nh7QWCb4KBs6k+MAC/uk5p
K3un0lpscaBC/Nr3ePxwniDL3DQs3fqXYjltUIbX94bycLAFCN0TSxCYI3DbquaO
h6FgVXzy6DFMtcQScsdKK6/cw/S55LjgWMuA0Ze0KGuBKie/2Hs=
=GP2C
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.