Re: ja.tmac doesn't seem to work

Hi,

I've verified that groff 1.24.0.rc1 works as expected.

Thanks,
Koichi

On 1/21/26 14:36, G. Branden Robinson wrote:
> Hi Kubo-san,
> 
> At 2026-01-21T11:26:14+0900, KUBO, Koichi wrote:
>> The .class and .cflags requests used by ja.tmac don't seem to work as
>> expected.  The steps I've confirmed are as follows:
> [...]
>> When troff is specified with -mja, it should output \[u3042] ... across
>> multiple lines, but it only outputs one line.
> [...]
>> The results seem to be the same whether or not -mja is specified.
> [...]
>> The troff version is:
>>
>> $ troff -v
>> GNU troff (groff) version 1.23.0.4049-1828
> [...]
>> I think the cause is the following code in void charinfo::get_flags()
>> in src/roff/troff/input.cpp:
>>
>>      if (ci->contains(get_unicode_mapping() >= 0)) {
>>
>> Isn't this code a typo of:
>>
>>      if (ci->contains(get_unicode_mapping())) {
>>
>> Could you please check this?
> 
> Yes.  I introduced this bug on 4 September and fixed it on 1 December.
> 
> commit c545d5192dcf7beb643c8ce362fa3b17fcf1d033
> Author: G. Branden Robinson <[email protected]>
> Date:   Mon Dec 1 17:44:45 2025 -0600
> 
>      [troff]: Fix Savannah #67570.
> 
>      * src/roff/troff/input.cpp (charinfo::get_flags): Fix inadvertent
>        regression caused by fumbled refactoring, wherein I inexplicably
>        mistook a Boolean-valued return type for an `int`-valued one.
>        (`contains()` sounds Boolean to me now, in the cold light of day.)
> 
>      Fixes <https://savannah.gnu.org/bugs/?67570>.  Thanks to Dave Kemper for
>      the report.  Problem introduced by me in commit 77d8f728d, 4 September.
> 
> Please consider trying the groff 1.24.0.rc1 release candidate.
> 
> https://lists.gnu.org/archive/html/info-groff/2026-01/msg00000.html
> 
> Regards,
> Branden