To bust or not to bust: the C/C++ code freeze for a (poor man's) fuzzer-provoked SEGV
"G. Branden Robinson" <[email protected]>
| Newsgroups | gmane.comp.printing.groff.general |
|---|---|
| Message-ID | <20260128190058.vtjzdmemdq7y4d7s@illithid> |
Hi folks, Bruno Haible found a SEGV in the formatter by putting the GNU distribution archive "sed-4.8.tar.xz" on the input. See <https://savannah.gnu.org/bugs/?67978>. I _was_ going to bust the C/C++ code freeze for this and whatever yarn unravelled from it...I've already started to find some, as seen in comment #4 to the foregoing ticket. However, Bruno argues against that. > I wouldn't delay the 1.24.0 release for this, because > > It's an absurd, unrealistic input. > > Complete handling of such inputs would take several weeks. When I > did input fuzzing on the 'xgettext' program, it took me two weeks > to fix the various findings. And for groff, Ingo Schwarze > estimates it to be "at least a month of full-time work", see > https://lists.nongnu.org/archive/html/groff/2019-12/msg00078.html > > You have 15 pages of NEWS accumulated for this release. Get the > new features out to the users! Personally I feel conflicted; my pride as a software engineer is in conflict with my goals as a release manager. (Usually, the former wins, which is why I have not yet managed to accelerate groff's traditionally slow release cadence.) However, a quick check reveals that this problem is not new to groff's 1.24.0 release candidates. groff 1.23.0, 1.22.4, and 1.22.3 all also core dump on the same input. That pushes me back toward just proceeding, and not even writing a release note about it, since it's a defect of long standing and (now) tracked in Savannah, and we've never historically blasted readers of our release notes with lists of _open_ (non-Wish-Severity) Savannah tickets. So I guess I'll just wince about this and pounce on it when the 1.25 cycle opens, or masticate it in a private branch while waiting for for RC or release feedback. I welcome the community's viewpoints on the matter. Regards, Branden
signature.asc
(application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEh3PWHWjjDgcrENwa0Z6cfXEmbc4FAml6XOIACgkQ0Z6cfXEm bc6Cog/8DyLaokBromuq/hEaoMi/3TjT5gVOjwncFNN0NfY68+6VT01TPIhZotEo GGJX5jcQAT4qY8K7jWbpIY3uP5rVad25COG2REEXiYs+7fCFo4gVPMLx2JGgY0xK u3+8qmBp0n+RY+xlyJT2ehzW3KPAX+ijoIkzM6enGdrin7eCtyt5UkyanBCXpedv 0KSyYEqJMtMKomKY9NHsvLrWsQnT/3zcL4Eeb7oH9VgRlf8bsQtkJ/myfxAmHVC1 JYmEIPqb7BzPXGgCN/W2EFdngtlE8TSjkvi61JPKoSmOxFqZE26pIsGGBRnn1KyH Kw0RU4zY/TQDMNWp3QCKCr7yaN9O3He3aIDHPLyyh+oR96WfBIFLFH46sNjlDy0t CIUjsAk85ZYOCI07kSMFJDY/1IC/Hv7qCTIWCCQ8pmGPBbHA4VxnbUASqjZmaaOJ DsvXRYdw8BL6EUANvy/wPIj8F49ISsfhcHliLXcMjgE0O3ZI3XeUSdMmMkb6dzvQ 34PDsww1uBnm6kVTVfitwmzpYQhukJxIcdojbhFtPruVWjM7xd+/pS7s6kgV9Kl8 IuzOHQaHSREseeabOcK3ALmSUgzGMJyd5l9omOvgOUVRR84gBm8iuT526bOLes3b 0fQAbC2PUwlSuYYk3KCkCiD3dDQXYmLr/3eQl/ZZksKxHsiYcTU= =v9pK -----END PGP SIGNATURE-----